SemianiakaVY/elsa-core
1
0
Fork 0
Code Issues Pull requests Actions 1 Packages Projects Releases Wiki Activity

Update model immediately to avoid race conditions between UI actions and delayed model updates

Browse source
This commit is contained in:
Sipke Schoorstra 2022-12-01 22:24:17 +01:00
parent 49de352011
commit edb4782971
1 changed files with 4 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/designer/elsa-workflows-designer/src/modules/workflow-definitions/components/editor.tsx
View file

@ -32,8 +32,6 @@ export class WorkflowDefinitionEditor {
private canvas: HTMLElsaCanvasElement;
private container: HTMLDivElement;
private toolbox: HTMLElsaWorkflowDefinitionEditorToolboxElement;
private readonly emitActivityChangedDebounced: (e: ActivityPropertyChangedEventArgs) => void;
private readonly updateModelDebounced: () => void;
private readonly saveChangesDebounced: () => void;
private readonly workflowDefinitionApi: WorkflowDefinitionsApi;
@ -42,8 +40,6 @@ export class WorkflowDefinitionEditor {
this.pluginRegistry = Container.get(PluginRegistry);
this.activityNameFormatter = Container.get(ActivityNameFormatter);
this.portProviderRegistry = Container.get(PortProviderRegistry);
this.emitActivityChangedDebounced = debounce(this.emitActivityChanged, 100);
this.updateModelDebounced = debounce(this.updateModel, 10);
this.saveChangesDebounced = debounce(this.saveChanges, 1000);
this.workflowDefinitionApi = Container.get(WorkflowDefinitionsApi);
}
@ -89,7 +85,7 @@ export class WorkflowDefinitionEditor {
@Listen('graphUpdated')
private async handleGraphUpdated(e: CustomEvent<GraphUpdatedArgs>) {
this.updateModelDebounced();
await this.updateModel();
this.saveChangesDebounced();
}
@ -241,12 +237,12 @@ export class WorkflowDefinitionEditor {
});
await this.updateModel();
this.emitActivityChangedDebounced({...e.detail, workflowEditor: this.el});
await this.emitActivityChanged(e.detail.activity, e.detail.propertyName);
this.saveChangesDebounced();
}
private onWorkflowPropsUpdated = (e: CustomEvent<WorkflowDefinitionPropsUpdatedArgs>) => {
this.updateModelDebounced();
private onWorkflowPropsUpdated = async (e: CustomEvent<WorkflowDefinitionPropsUpdatedArgs>) => {
await this.updateModel();
this.saveChangesDebounced();
}