SemianiakaVY/elsa-core
1
0
Fork 0
Code Issues Pull requests Actions 1 Packages Projects Releases Wiki Activity

Merge pull request #6283 from elsa-workflows/fix/array-wf-type

Browse source 
Refactor array type handling in variable and JSON converters
This commit is contained in:
Sipke Schoorstra 2025-01-10 14:38:54 +01:00 committed by GitHub
parent 8e27cf59a8 d759624321
commit e395361bfd
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/modules/Elsa.Workflows.Core/Serialization/Converters/TypeJsonConverter.cs
View file

@ -36,7 +36,7 @@ public class TypeJsonConverter : JsonConverter<Type>
{
var elementTypeAlias = typeAlias[..^"[]".Length];
var elementType = _wellKnownTypeRegistry.TryGetType(elementTypeAlias, out var t) ? t : Type.GetType(elementTypeAlias)!;
return typeof(List<>).MakeGenericType(elementType);
return elementType.MakeArrayType();
}
return _wellKnownTypeRegistry.TryGetType(typeAlias, out var type) ? type : Type.GetType(typeAlias);

2
src/modules/Elsa.Workflows.Management/Mappers/VariableDefinitionMapper.cs
View file

@ -30,7 +30,7 @@ public class VariableDefinitionMapper
if (!_wellKnownTypeRegistry.TryGetTypeOrDefault(source.TypeName, out var type))
return null;
var valueType = source.IsArray ? typeof(ICollection<>).MakeGenericType(type) : type;
var valueType = source.IsArray ? type.MakeArrayType() : type;
var variableGenericType = typeof(Variable<>).MakeGenericType(valueType);
var variable = (Variable)Activator.CreateInstance(variableGenericType)!;