SemianiakaVY/elsa-core
1
0
Fork 0
Code Issues Pull requests Actions 1 Packages Projects Releases Wiki Activity

Resolve #486 - Signal input is emitted as output

Browse source 
It actually turns out that no change is required to the SignalReceived
activity in order to achieve this.  As these unit tests prove & document,
that is already the current behaviour.
This commit is contained in:
Craig Fowler 2021-02-27 17:45:22 +00:00 committed by Sipke Schoorstra
parent 2620905828
commit e340a37d93
1 changed files with 81 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

81
test/unit/Elsa.UnitTests/Activities/Signaling/SignalReceivedTests.cs Normal file
View file

@ -0,0 +1,81 @@
using System.Threading.Tasks;
using Elsa.Services.Models;
using Elsa.Activities.Signaling.Models;
using Xunit;
using Elsa.ActivityResults;
using System.Linq;
namespace Elsa.Activities.Signaling
{
public class SignalReceivedTests
{
[Theory(DisplayName = "The CanExecuteAsync method should return a task of false if the signal name does not match the triggered signal"), AutoMoqData]
public async Task CanExecuteAsyncShouldReturnATaskOfFalseIfTheSignalNameDoesNotMatch(SignalReceived sut,
Signal triggeredSignal)
{
var context = new ActivityExecutionContext(default, default, default, triggeredSignal, default, default);
triggeredSignal.SignalName = "Yes";
sut.Signal = "No";
var result = await sut.CanExecuteAsync(context);
Assert.False(result);
}
[Theory(DisplayName = "The CanExecuteAsync method should return a task of true if the signal name matches the triggered signal"), AutoMoqData]
public async Task CanExecuteAsyncShouldReturnATaskOfTrueIfTheSignalNameMatchs(SignalReceived sut,
string signalName,
Signal triggeredSignal)
{
var context = new ActivityExecutionContext(default, default, default, triggeredSignal, default, default);
triggeredSignal.SignalName = signalName;
sut.Signal = signalName;
var result = await sut.CanExecuteAsync(context);
Assert.True(result);
}
[Theory(DisplayName = "The CanExecuteAsync method should return a task of false if the input from the context is not a triggered signal"), AutoMoqData]
public async Task CanExecuteAsyncShouldReturnATaskOfFalseIfTheInputIsNotATriggeredSignal(SignalReceived sut,
string signalName,
object notASignal)
{
var context = new ActivityExecutionContext(default, default, default, notASignal, default, default);
sut.Signal = signalName;
var result = await sut.CanExecuteAsync(context);
Assert.False(result);
}
[Theory(DisplayName = "The ResumeAsync method should return a combined 'Done' Outcome & Output result"), AutoMoqData]
public async Task ResumeAsyncShouldReturnCombinedDoneAndOutputResult(SignalReceived sut, Signal triggeredSignal, object signalInput)
{
var context = new ActivityExecutionContext(default, default, default, triggeredSignal, default, default);
triggeredSignal.Input = signalInput;
var result = await sut.ResumeAsync(context);
Assert.True((result is CombinedResult combinedResult)
&& combinedResult.Results.Any(res => res is OutcomeResult outcome && outcome.Outcomes.Any(o => o == OutcomeNames.Done))
&& combinedResult.Results.Any(res => res is OutputResult),
$"The result is {nameof(CombinedResult)} which contains both a {nameof(OutcomeResult)} (of \"Done\") and a {nameof(OutputResult)}.");
}
[Theory(DisplayName = "The ResumeAsync method should include the original signal input within the Output result"), AutoMoqData]
public async Task ResumeAsyncShouldReturnOriginalSignalInputWithinDoneResult(SignalReceived sut, Signal triggeredSignal, object signalInput)
{
var context = new ActivityExecutionContext(default, default, default, triggeredSignal, default, default);
triggeredSignal.Input = signalInput;
var result = await sut.ResumeAsync(context);
var resultOutput = ((CombinedResult) result).Results
.OfType<OutputResult>()
?.FirstOrDefault()
?.Output;
Assert.Same(signalInput, resultOutput);
}
}
}