SemianiakaVY/elsa-core
1
0
Fork 0
Code Issues Pull requests Actions 1 Packages Projects Releases Wiki Activity

Merge remote-tracking branch 'origin/develop/3.5.0' into develop/3.6.0

Browse source
This commit is contained in:
Sipke Schoorstra 2025-08-04 15:44:17 +02:00
parent 6d38ebbc97 aab80dd30b
commit dd8a6f5866
No known key found for this signature in database
GPG key ID: 5C10502B28A4268F
3 changed files with 40 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
doc/adr/0004-activity-execution-snapshots.md Normal file
View file

@ -0,0 +1,28 @@
# 4. Activity Execution Snapshots
**Date:** 2025-08-04
**Status:** Accepted
## Context
Today the `ActivityExecutionContext` is persisted only at *commit points*.
If an activity references a workflow variable that changes after it has run—but before the next commit—the value saved is the *later* value, not the one that existed when the activity executed.
As a result, the Workflow Instance Viewer shows misleading data: users expect to see the variable values *at execution time*, not at commit time.
## Decision
Capture a **snapshot** of the `ActivityExecutionContext` immediately when an activity executes.
The snapshot must include:
* All workflow variables and their values at that moment.
* Any other execution-specific metadata required for replay or inspection.
The snapshot is created by serializing the `ActivityExecutionRecord` to JSON and storing it in the database.
The persistence layer will be updated to handle this new snapshot field, ensuring it is stored alongside the activity execution record.
## Consequences
* The Workflow Instance Viewer will now display the exact state that the activity saw, eliminating confusion during debugging and auditing.
* Additional storage will be consumed for each snapshot. We accept this overhead in exchange for correctness and developer experience.
* Existing persistence schemas will require a non-breaking migration to store the snapshot payload.
* Workflow instances before this change will not have snapshots, but they will still be replayable even if the variable values are not accurate at execution time.

18
doc/adr/graph.dot
View file

@ -1,10 +1,12 @@
digraph {
node [shape=plaintext];
subgraph {
_1 [label="1. Record architecture decisions"; URL="0001-record-architecture-decisions.html"];
_2 [label="2. Fault Propagation from Child to Parent Activities"; URL="0002-fault-propagation-from-child-to-parent-activities.html"];
_1 -> _2 [style="dotted", weight=1];
_3 [label="3. Direct Bookmark Management in WorkflowExecutionContext"; URL="0003-direct-bookmark-management-in-workflowexecutioncontext.html"];
_2 -> _3 [style="dotted", weight=1];
}
node [shape = plaintext];
subgraph {
_1 [label = "1. Record architecture decisions"; URL = "0001-record-architecture-decisions.html"];
_2 [label = "2. Fault Propagation from Child to Parent Activities"; URL ="0002-fault-propagation-from-child-to-parent-activities.html"];
_1 -> _2 [style= "dotted", weight = 1];
_3 [label = "3. Direct Bookmark Management in WorkflowExecutionContext"; URL = "0003-direct-bookmark-management-in-workflowexecutioncontext.html"];
_2 -> _3 [style = "dotted", weight = 1];
_4 [label ="4. Activity Execution Snapshots"; URL = "0004-activity-execution-snapshots.html"];
_3 -> _4 [style = "dotted", weight = 1];
}
}

3
doc/adr/toc.md
View file

@ -2,4 +2,5 @@
* [1. Record architecture decisions](0001-record-architecture-decisions.md)
* [2. Fault Propagation from Child to Parent Activities](0002-fault-propagation-from-child-to-parent-activities.md)
* [3. Direct Bookmark Management in WorkflowExecutionContext](0003-direct-bookmark-management-in-workflowexecutioncontext.md)
* [3. Direct Bookmark Management in WorkflowExecutionContext](0003-direct-bookmark-management-in-workflowexecutioncontext.md)
* [4. Activity Execution Snapshots](0004-activity-execution-snapshots.md)