SemianiakaVY/elsa-core
1
0
Fork 0
Code Issues Pull requests Actions 1 Packages Projects Releases Wiki Activity

Add distributed locking to MassTransitWorkflowDispatcher (#5418)

Browse source 
This commit introduces a distributed lock to the MassTransitWorkflowDispatcher to prevent concurrent updates to the workflow instance. The lock is acquired before any interaction with the workflow instance and is released after the update operation is complete.
This commit is contained in:
Sipke Schoorstra 2024-05-21 21:32:27 +02:00 committed by GitHub
parent 8289ae2cdf
commit d89a07d391
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/modules/Elsa.MassTransit/Services/MassTransitWorkflowDispatcher.cs
View file

@ -11,6 +11,7 @@ using Elsa.Workflows.Runtime.Models;
using Elsa.Workflows.Runtime.Requests;
using Elsa.Workflows.Runtime.Responses;
using MassTransit;
using Medallion.Threading;
using Microsoft.Extensions.Logging;
namespace Elsa.MassTransit.Services;
@ -26,6 +27,7 @@ public class MassTransitWorkflowDispatcher(
IBookmarkHasher bookmarkHasher,
ITriggerStore triggerStore,
IBookmarkStore bookmarkStore,
IDistributedLockProvider distributedLockProvider,
ILogger<MassTransitWorkflowDispatcher> logger)
: IWorkflowDispatcher
{
@ -163,6 +165,8 @@ public class MassTransitWorkflowDispatcher(
if (input != null || properties != null)
{
// Need to acquire a lock on the workflow instance to prevent concurrent updates.
await using var distributedLock = await distributedLockProvider.AcquireLockAsync(workflowInstanceId, TimeSpan.FromMinutes(2), cancellationToken);
var workflowInstance = await workflowInstanceManager.FindByIdAsync(workflowInstanceId, cancellationToken);
if (workflowInstance == null)