SemianiakaVY/elsa-core
1
0
Fork 0
Code Issues Pull requests Actions 1 Packages Projects Releases Wiki Activity

Throw InputEvaluationException for input evaluation errors

Browse source 
Introduced `InputEvaluationException` to encapsulate errors during input evaluation in `ActivityExecutionContextExtensions`. Refactored the input evaluation logic by adding a core evaluation method to improve error handling and clarity.
This commit is contained in:
Sipke Schoorstra 2025-09-16 20:37:05 +02:00
parent b613ff6b61
commit d4a2a5f03a
No known key found for this signature in database
GPG key ID: 5C10502B28A4268F
2 changed files with 19 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/modules/Elsa.Workflows.Core/Exceptions/InputEvaluationException.cs Normal file
View file

@ -0,0 +1,6 @@
namespace Elsa.Workflows.Exceptions;
public class InputEvaluationException(string inputName, string message, Exception exception) : Exception(message, exception)
{
public string InputName { get; } = inputName;
}

13
src/modules/Elsa.Workflows.Core/Extensions/ActivityExecutionContextExtensions.InputEvaluation.cs
View file

@ -3,6 +3,7 @@ using Elsa.Expressions.Contracts;
using Elsa.Expressions.Helpers;
using Elsa.Expressions.Models;
using Elsa.Workflows;
using Elsa.Workflows.Exceptions;
using Elsa.Workflows.Models;
// ReSharper disable once CheckNamespace
@ -68,6 +69,18 @@ public static partial class ActivityExecutionContextExtensions
}
private static async Task<object?> EvaluateInputPropertyAsync(this ActivityExecutionContext context, ActivityDescriptor activityDescriptor, InputDescriptor inputDescriptor)
{
try
{
return await EvaluateInputPropertyCoreAsync(context, activityDescriptor, inputDescriptor);
}
catch (Exception e)
{
throw new InputEvaluationException(inputDescriptor.Name, $"Failed to evaluate activity input '{inputDescriptor.Name}'", e);
}
}
private static async Task<object?> EvaluateInputPropertyCoreAsync(this ActivityExecutionContext context, ActivityDescriptor activityDescriptor, InputDescriptor inputDescriptor)
{
var activity = context.Activity;
var defaultValue = inputDescriptor.DefaultValue;