SemianiakaVY/elsa-core
1
0
Fork 0
Code Issues Pull requests Actions 1 Packages Projects Releases Wiki Activity

Simplify activity context handling in workflows.

Browse source 
Replaced `GetActiveChildren` with a direct `Children` property in `Flowchart.cs` to streamline logic. Removed redundant `GetDescendents`, `GetActiveChildren`, and `GetChildren` methods from `ActivityExecutionContextExtensions.cs`. Also updated GitHub workflows to allow performance-related branches.
This commit is contained in:
Sipke Schoorstra 2025-01-20 18:29:13 +01:00
parent a49bf0c05f
commit d31661926d
3 changed files with 2 additions and 45 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
.github/workflows/packages.yml vendored
View file

@ -5,6 +5,7 @@ on:
branches:
- 'main'
- 'bug/*'
- 'perf/*'
release:
types: [ prereleased, published ]
env:

2
src/modules/Elsa.Workflows.Core/Activities/Flowchart/Activities/Flowchart.cs
View file

@ -227,7 +227,7 @@ public class Flowchart : Container
if (!hasPendingWork)
{
var hasFaultedActivities = context.GetActiveChildren().Any(x => x.Status == ActivityStatus.Faulted);
var hasFaultedActivities = context.Children.Any(x => x.Status == ActivityStatus.Faulted);
if (!hasFaultedActivities)
{

44
src/modules/Elsa.Workflows.Core/Extensions/ActivityExecutionContextExtensions.cs
View file

@ -197,50 +197,6 @@ public static partial class ActivityExecutionContextExtensions
}
}
/// <summary>
/// Returns a flattened list of the current context's descendants.
/// </summary>
public static IEnumerable<ActivityExecutionContext> GetDescendents(this ActivityExecutionContext context)
{
var children = context.WorkflowExecutionContext.ActivityExecutionContexts.Where(x => x.ParentActivityExecutionContext == context);
foreach (var child in children)
{
yield return child;
foreach (var descendent in GetDescendents(child))
yield return descendent;
}
}
/// <summary>
/// Returns a flattened list of the current context's immediate active children.
/// </summary>
public static IEnumerable<ActivityExecutionContext> GetActiveChildren(this ActivityExecutionContext context) =>
context.WorkflowExecutionContext.ActivityExecutionContexts.Where(x => x.ParentActivityExecutionContext == context);
/// <summary>
/// Returns a flattened list of the current context's immediate children.
/// </summary>
public static IEnumerable<ActivityExecutionContext> GetChildren(this ActivityExecutionContext context) =>
context.WorkflowExecutionContext.ActivityExecutionContexts.Where(x => x.ParentActivityExecutionContext == context);
/// <summary>
/// Returns a flattened list of the current context's descendants.
/// </summary>
public static IEnumerable<ActivityExecutionContext> GetDescendants(this ActivityExecutionContext context)
{
var children = context.WorkflowExecutionContext.ActivityExecutionContexts.Where(x => x.ParentActivityExecutionContext == context).ToList();
foreach (var child in children)
{
yield return child;
foreach (var descendant in child.GetDescendants())
yield return descendant;
}
}
/// <summary>
/// Send a signal up the current hierarchy of ancestors.
/// </summary>