From cd2d0efef55194b581c1cd734491dd551e0dd2a6 Mon Sep 17 00:00:00 2001
From: Sipke Schoorstra <sipkeschoorstra@outlook.com>
Date: Fri, 24 Jan 2025 19:50:02 +0100
Subject: [PATCH] Refactor MongoDbStore to use EmptyToNull for TenantId
 assignments and add StringExtensions for null handling

---
 src/modules/Elsa.MongoDb/Common/MongoDbStore.cs         | 6 +++---
 src/modules/Elsa.MongoDb/Extensions/StringExtensions.cs | 6 ++++++
 2 files changed, 9 insertions(+), 3 deletions(-)
 create mode 100644 src/modules/Elsa.MongoDb/Extensions/StringExtensions.cs

diff --git a/src/modules/Elsa.MongoDb/Common/MongoDbStore.cs b/src/modules/Elsa.MongoDb/Common/MongoDbStore.cs
index c070fd188..9c5c3b674 100644
--- a/src/modules/Elsa.MongoDb/Common/MongoDbStore.cs
+++ b/src/modules/Elsa.MongoDb/Common/MongoDbStore.cs
@@ -405,7 +405,7 @@ public class MongoDbStore<TDocument>(IMongoCollection<TDocument> collection, ITe
         if (typeof(Entity).IsAssignableFrom(typeof(TDocument)))
         {
             var tenant = tenantAccessor.Tenant;
-            var tenantId = tenant?.Id;
+            var tenantId = tenant?.Id.EmptyToNull();
             queryable = queryable.Where(x => (x as Entity)!.TenantId == tenantId);
         }
 
@@ -418,7 +418,7 @@ public class MongoDbStore<TDocument>(IMongoCollection<TDocument> collection, ITe
         var tenantId = tenant?.Id;
 
         if (document is Entity tenantDocument)
-            tenantDocument.TenantId = tenantId;
+            tenantDocument.TenantId = tenantId.EmptyToNull();
     }
 
     private void ApplyTenantId(IEnumerable<TDocument> documents)
@@ -429,7 +429,7 @@ public class MongoDbStore<TDocument>(IMongoCollection<TDocument> collection, ITe
         foreach (var document in documents)
         {
             if (document is Entity tenantDocument)
-                tenantDocument.TenantId = tenantId;
+                tenantDocument.TenantId = tenantId.EmptyToNull();
         }
     }
 }
\ No newline at end of file
diff --git a/src/modules/Elsa.MongoDb/Extensions/StringExtensions.cs b/src/modules/Elsa.MongoDb/Extensions/StringExtensions.cs
new file mode 100644
index 000000000..cc806f04a
--- /dev/null
+++ b/src/modules/Elsa.MongoDb/Extensions/StringExtensions.cs
@@ -0,0 +1,6 @@
+namespace Elsa.MongoDb.Extensions;
+
+public static class StringExtensions
+{
+    public static string? EmptyToNull(this string? value) => string.IsNullOrWhiteSpace(value) ? null : value;
+}
\ No newline at end of file