SemianiakaVY/elsa-core
1
0
Fork 0
Code Issues Pull requests Actions 1 Packages Projects Releases Wiki Activity

Enhanced Delete of variable persistence manager to allow drivers filtering with tags (#6558) (#6559)

Browse source
This commit is contained in:
MariusVuscanNx 2025-04-04 12:52:58 +03:00 committed by GitHub
parent bd2fcb4d21
commit be455ee11b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 17 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/modules/Elsa.Workflows.Core/Contracts/IVariablePersistenceManager.cs
View file

@ -21,10 +21,16 @@ public interface IVariablePersistenceManager
/// <summary>
/// Deletes the specified variables from the <see cref="ActivityExecutionContext"/>.
/// </summary>
Task DeleteVariablesAsync(ActivityExecutionContext context);
/// <param name="context"></param>
/// <param name="includeTags"></param>
/// <returns></returns>
Task DeleteVariablesAsync(ActivityExecutionContext context, IEnumerable<string>? includeTags = default);
/// <summary>
/// Deletes the specified variables from the <see cref="WorkflowExecutionContext"/>.
/// </summary>
Task DeleteVariablesAsync(WorkflowExecutionContext context);
/// <param name="context"></param>
/// <param name="includeTags"></param>
/// <returns></returns>
Task DeleteVariablesAsync(WorkflowExecutionContext context, IEnumerable<string>? includeTags = default);
}

13
src/modules/Elsa.Workflows.Core/Services/VariablePersistenceManager.cs
View file

@ -100,11 +100,12 @@ public class VariablePersistenceManager(IStorageDriverManager storageDriverManag
}
/// <inheritdoc />
public async Task DeleteVariablesAsync(ActivityExecutionContext context)
public async Task DeleteVariablesAsync(ActivityExecutionContext context, IEnumerable<string>? includeTags = default)
{
var register = context.ExpressionExecutionContext.Memory;
var variableList = GetLocalVariables(context).ToList();
var cancellationToken = context.CancellationToken;
var includeTagsList = includeTags?.ToList();
foreach (var variable in variableList)
{
@ -116,6 +117,9 @@ public class VariablePersistenceManager(IStorageDriverManager storageDriverManag
if (driver == null)
continue;
if (includeTagsList != null && !driver.Tags.Any(includeTagsList.Contains))
continue;
var id = GetStateId(variable);
var storageDriverContext = new StorageDriverContext(context, variable, cancellationToken);
@ -125,13 +129,14 @@ public class VariablePersistenceManager(IStorageDriverManager storageDriverManag
}
/// <inheritdoc />
public async Task DeleteVariablesAsync(WorkflowExecutionContext context)
public async Task DeleteVariablesAsync(WorkflowExecutionContext context, IEnumerable<string>? includeTags = default)
{
var activityContexts = context.ActivityExecutionContexts.ToList();
var includeTagsList = includeTags?.ToList();
foreach (var activityContext in activityContexts)
{
await DeleteVariablesAsync(activityContext);
await DeleteVariablesAsync(activityContext, includeTagsList);
}
}