SemianiakaVY/elsa-core
1
0
Fork 0
Code Issues Pull requests Actions 1 Packages Projects Releases Wiki Activity

Improve RemoveScheduledTriggers to always try and unschedule timers

Browse source 
This prevents an issue when a custom activity e.g. Sleep dervices from Timer
This commit is contained in:
Sipke Schoorstra 2021-05-21 13:30:01 +02:00
parent b28dfa92ee
commit bd012d0965
1 changed files with 3 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/activities/Elsa.Activities.Temporal.Common/Handlers/RemoveScheduledTriggers.cs
View file

@ -1,5 +1,4 @@
using System.Linq;
using System.Threading;
using System.Threading;
using System.Threading.Tasks;
using Elsa.Activities.Temporal.Common.Services;
using Elsa.Events;
@ -9,15 +8,13 @@ namespace Elsa.Activities.Temporal.Common.Handlers
{
public class RemoveScheduledTriggers : INotificationHandler<BlockingActivityRemoved>, INotificationHandler<WorkflowDefinitionPublished>, INotificationHandler<WorkflowDefinitionRetracted>
{
private readonly string[] _supportedTypes = { nameof(Timer), nameof(StartAt), nameof(Cron) };
private readonly IWorkflowScheduler _workflowScheduler;
public RemoveScheduledTriggers(IWorkflowScheduler workflowScheduler) => _workflowScheduler = workflowScheduler;
public async Task Handle(BlockingActivityRemoved notification, CancellationToken cancellationToken)
{
if (!_supportedTypes.Contains(notification.BlockingActivity.ActivityType))
return;
// TODO: Consider introducing a "stereotype" field for activities to exit early in case they are not stereotyped as "temporal".
await _workflowScheduler.UnscheduleWorkflowAsync(
null,
notification.WorkflowExecutionContext.WorkflowInstance.Id,