From b99c0c84126e78a83be0dadbb649b6f0cca14ad3 Mon Sep 17 00:00:00 2001 From: Sipke Schoorstra Date: Sat, 14 Dec 2024 20:01:11 +0100 Subject: [PATCH] Disable flaky test in BulkDispatchWorkflowsTests. Commented out a test that was marked as flaky and skipped. This ensures the test suite remains reliable while the issue is addressed in the future. --- .../BulkDispatchWorkflowsTests.cs | 28 +++++++++---------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/test/component/Elsa.Workflows.ComponentTests/Scenarios/BulkDispatchWorkflows/BulkDispatchWorkflowsTests.cs b/test/component/Elsa.Workflows.ComponentTests/Scenarios/BulkDispatchWorkflows/BulkDispatchWorkflowsTests.cs index a29ae9950..f522ee010 100644 --- a/test/component/Elsa.Workflows.ComponentTests/Scenarios/BulkDispatchWorkflows/BulkDispatchWorkflowsTests.cs +++ b/test/component/Elsa.Workflows.ComponentTests/Scenarios/BulkDispatchWorkflows/BulkDispatchWorkflowsTests.cs @@ -21,20 +21,20 @@ public class BulkDispatchWorkflowsTests : AppComponentTest _signalManager = Scope.ServiceProvider.GetRequiredService(); } - /// - /// Dispatches and waits for child workflows to complete. - /// - [Fact(Skip = "This test is flaky and needs to be fixed.")] - public async Task DispatchAndWaitWorkflow_ShouldWaitForChildWorkflowToComplete() - { - var workflowClient = await _workflowRuntime.CreateClientAsync(); - await workflowClient.CreateInstanceAsync(new CreateWorkflowInstanceRequest - { - WorkflowDefinitionHandle = WorkflowDefinitionHandle.ByDefinitionId(GreetEmployeesWorkflow.DefinitionId, VersionOptions.Published) - }); - await workflowClient.RunInstanceAsync(RunWorkflowInstanceRequest.Empty); - await _signalManager.WaitAsync("Completed"); - } + // /// + // /// Dispatches and waits for child workflows to complete. + // /// + // [Fact(Skip = "This test is flaky and needs to be fixed.")] + // public async Task DispatchAndWaitWorkflow_ShouldWaitForChildWorkflowToComplete() + // { + // var workflowClient = await _workflowRuntime.CreateClientAsync(); + // await workflowClient.CreateInstanceAsync(new CreateWorkflowInstanceRequest + // { + // WorkflowDefinitionHandle = WorkflowDefinitionHandle.ByDefinitionId(GreetEmployeesWorkflow.DefinitionId, VersionOptions.Published) + // }); + // await workflowClient.RunInstanceAsync(RunWorkflowInstanceRequest.Empty); + // await _signalManager.WaitAsync("Completed"); + // } /// /// Individual items are sent as input to child workflows.