SemianiakaVY/elsa-core
1
0
Fork 0
Code Issues Pull requests Actions 1 Packages Projects Releases Wiki Activity

Fix missing ports

Browse source
This commit is contained in:
Sipke Schoorstra 2023-03-02 10:08:27 +01:00
parent acd447cfc1
commit ae09881508
3 changed files with 8 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/designer/elsa-workflows-designer/src/modules/flowchart/default-activity-template.tsx
View file

@ -52,7 +52,7 @@ export class DefaultActivityTemplate {
{({nodeMap}) => {
const activity: Activity = nodeMap[activityId];
const ports = portProvider.getOutboundPorts({activityDescriptor, activity});
const embeddedPorts = ports.filter(x => x.mode == PortMode.Embedded && x.isBrowsable);
const embeddedPorts = ports.filter(x => x.mode == PortMode.Embedded && x.isBrowsable !== false);
const canStartWorkflow = activity?.canStartWorkflow;
const icon = this.icon;
const hasIcon = !!icon;

2
src/designer/elsa-workflows-designer/src/modules/workflow-definitions/components/toolbox-activities.tsx
View file

@ -52,7 +52,7 @@ export class ToolboxActivities {
buildModel = (): any => {
const browsableDescriptors = uniqBy(descriptorsStore.activityDescriptors
.filter(x => x.isBrowsable)
.filter(x => x.isBrowsable !== false)
.sort((a, b) => a.version > b.version ? 1 : -1), x => `${x.typeName}:${x.version}`);
const categorizedActivitiesLookup = groupBy(browsableDescriptors, x => x.category);

13
src/designer/elsa-workflows-designer/src/services/activity-walker.ts
View file

@ -81,10 +81,12 @@ function walkRecursive(node: ActivityNode, activity: Activity, collectedActiviti
}
if (childNode !== node) {
childNode.parents.push(node);
node.children.push(childNode);
collectedActivities.add(port.activity);
walkRecursive(childNode, port.activity, collectedActivities, collectedNodes, descriptors);
if(!!childNode.activity) {
childNode.parents.push(node);
node.children.push(childNode);
collectedActivities.add(port.activity)
walkRecursive(childNode, port.activity, collectedActivities, collectedNodes, descriptors);
}
}
}
}
@ -104,9 +106,6 @@ function getPorts(node: ActivityNode, activity: Activity, descriptors: Array<Act
for (const port of ports) {
const value = portProvider.resolvePort(port.name, portProviderContext);
if (!value)
continue;
if (Array.isArray(value)) {
const activities = value as Array<Activity>;
activityPorts = [...activityPorts, ...activities.map(x => ({port: port.name, activity: x}))];