SemianiakaVY/elsa-core
1
0
Fork 0
Code Issues Pull requests Actions 1 Packages Projects Releases Wiki Activity

Update bulk delete endpoints and request model

Browse source 
Refactor the bulk delete endpoint to include a new primary route while deprecating the old one. Expand the request model to support workflow definition filters and adjust response instantiation for clarity. Update obsolete API route prefix guidance for consistency across modules.
This commit is contained in:
Sipke Schoorstra 2025-03-07 10:04:41 +01:00
parent 44b61aa24e
commit a9eb326c5e
No known key found for this signature in database
GPG key ID: 5C10502B28A4268F
3 changed files with 15 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/modules/Elsa.Http/Options/HttpActivityOptions.cs
View file

@ -20,7 +20,7 @@ public class HttpActivityOptions
/// <summary>
/// The prefix used for API routes.
/// </summary>
[Obsolete("Use ElsaApiOptions from Elsa.Workflows.Api instead.")]
[Obsolete("Use ApiEndpointOptions from Elsa.Workflows.Api instead.")]
public string ApiRoutePrefix { get; set; } = "elsa/api";
/// <summary>

14
src/modules/Elsa.Workflows.Api/Endpoints/WorkflowInstances/BulkDelete/Endpoint.cs
View file

@ -10,15 +10,23 @@ internal class BulkDelete(IWorkflowInstanceManager store) : ElsaEndpoint<Request
{
public override void Configure()
{
Post("/bulk-actions/delete/workflow-instances/by-id");
Post(
"/bulk-actions/delete/workflow-instances",
"/bulk-actions/delete/workflow-instances/by-id" // Deprecated route.
);
ConfigurePermissions("delete:workflow-instances");
}
public override async Task<Response> ExecuteAsync(Request request, CancellationToken cancellationToken)
{
var filter = new WorkflowInstanceFilter { Ids = request.Ids };
var filter = new WorkflowInstanceFilter
{
Ids = request.Ids,
DefinitionId = request.WorkflowDefinitionId,
DefinitionIds = request.WorkflowDefinitionIds,
};
var count = await store.BulkDeleteAsync(filter, cancellationToken);
return new Response(count);
return new(count);
}
}

4
src/modules/Elsa.Workflows.Api/Endpoints/WorkflowInstances/BulkDelete/Models.cs
View file

@ -4,7 +4,9 @@ namespace Elsa.Workflows.Api.Endpoints.WorkflowInstances.BulkDelete;
internal class Request
{
public ICollection<string> Ids { get; set; } = default!;
public ICollection<string>? Ids { get; set; }
public string? WorkflowDefinitionId { get; set; }
public ICollection<string>? WorkflowDefinitionIds { get; set; }
}
internal class Response(long deletedCount)