SemianiakaVY/elsa-core
1
0
Fork 0
Code Issues Pull requests Actions 1 Packages Projects Releases Wiki Activity

adjusted with copilor review findings

Browse source
This commit is contained in:
Jelger Ribbers 2025-12-17 08:23:46 +01:00
parent 82acecdbd2
commit a2b1cf7766
3 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/modules/Elsa.Workflows.Api/Contracts/IWorkflowInstanceExportNameProvider.cs
View file

@ -14,5 +14,5 @@ public interface IWorkflowInstanceExportNameProvider
/// <param name="model">The export model representing the instance (optional).</param>
/// <param name="cancellationToken">Cancellation token.</param>
/// <returns>A filename safe for saving to disk.</returns>
Task<string> GetFileNameAsync(WorkflowInstance instance, object model, CancellationToken cancellationToken = default);
Task<string> GetFileNameAsync(WorkflowInstance instance, object? model, CancellationToken cancellationToken = default);
}

8
src/modules/Elsa.Workflows.Api/Endpoints/WorkflowInstances/Export/Endpoint.cs
View file

@ -31,7 +31,7 @@ internal class Export : ElsaEndpointWithMapper<Request, WorkflowInstanceMapper>
private readonly IWorkflowStateSerializer _workflowStateSerializer;
private readonly IPayloadSerializer _payloadSerializer;
private readonly ISafeSerializer _safeSerializer;
private readonly IWorkflowInstanceExportNameProvider _workFlowInstanceExportNameProvider;
private readonly IWorkflowInstanceExportNameProvider _workflowInstanceExportNameProvider;
/// <inheritdoc />
public Export(
@ -51,7 +51,7 @@ internal class Export : ElsaEndpointWithMapper<Request, WorkflowInstanceMapper>
_workflowStateSerializer = workflowStateSerializer;
_payloadSerializer = payloadSerializer;
_safeSerializer = safeSerializer;
_workFlowInstanceExportNameProvider = workFlowInstanceExportNameProvider;
_workflowInstanceExportNameProvider = workFlowInstanceExportNameProvider;
}
/// <inheritdoc />
@ -89,7 +89,7 @@ internal class Export : ElsaEndpointWithMapper<Request, WorkflowInstanceMapper>
var model = await CreateExportModelAsync(request, instance, cancellationToken);
var binaryJson = SerializeWorkflowInstance(model);
var fileName = await _workFlowInstanceExportNameProvider.GetFileNameAsync(instance, model, cancellationToken);
var fileName = await _workflowInstanceExportNameProvider.GetFileNameAsync(instance, model, cancellationToken);
var entry = zipArchive.CreateEntry(fileName, CompressionLevel.Optimal);
await using var entryStream = entry.Open();
@ -114,7 +114,7 @@ internal class Export : ElsaEndpointWithMapper<Request, WorkflowInstanceMapper>
var model = await CreateExportModelAsync(request, instance, cancellationToken);
var binaryJson = SerializeWorkflowInstance(model);
var fileName = await _workFlowInstanceExportNameProvider.GetFileNameAsync(instance, model, cancellationToken);
var fileName = await _workflowInstanceExportNameProvider.GetFileNameAsync(instance, model, cancellationToken);
await Send.BytesAsync(binaryJson, fileName, cancellation: cancellationToken);
}

2
src/modules/Elsa.Workflows.Api/Providers/DefaultWorkflowInstanceExportNameProvider.cs
View file

@ -7,7 +7,7 @@ namespace Elsa.Workflows.Api;
/// </summary>
public class DefaultWorkflowInstanceExportNameProvider : IWorkflowInstanceExportNameProvider
{
public Task<string> GetFileNameAsync(WorkflowInstance instance, object model, CancellationToken cancellationToken = default)
public Task<string> GetFileNameAsync(WorkflowInstance instance, object? model, CancellationToken cancellationToken = default)
{
var fileName = $"workflow-instance-{instance.Id.ToLowerInvariant()}.json";
return Task.FromResult(fileName);