From 90e8f03e38d19bd8ad7d4147567c92e04d1aaffa Mon Sep 17 00:00:00 2001
From: Sipke Schoorstra <sipkeschoorstra@outlook.com>
Date: Mon, 21 Mar 2022 20:32:47 +0100
Subject: [PATCH] Rename activity metadata to application properties

---
 src/core/Elsa.Core/Contracts/IActivity.cs                 | 2 +-
 src/core/Elsa.Core/Models/Activity.cs                     | 2 +-
 .../Serialization/Converters/FlowchartJsonConverter.cs    | 8 ++++----
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/core/Elsa.Core/Contracts/IActivity.cs b/src/core/Elsa.Core/Contracts/IActivity.cs
index 0c87c3df8..04fb355a6 100644
--- a/src/core/Elsa.Core/Contracts/IActivity.cs
+++ b/src/core/Elsa.Core/Contracts/IActivity.cs
@@ -25,7 +25,7 @@ public interface IActivity
     /// <summary>
     /// Can contain application-specific information about this activity.
     /// </summary>
-    IDictionary<string, object> Metadata { get; set; }
+    IDictionary<string, object> ApplicationProperties { get; set; }
     
     /// <summary>
     /// Invoked when the activity executes.
diff --git a/src/core/Elsa.Core/Models/Activity.cs b/src/core/Elsa.Core/Models/Activity.cs
index dd7b36b23..aa2320c10 100644
--- a/src/core/Elsa.Core/Models/Activity.cs
+++ b/src/core/Elsa.Core/Models/Activity.cs
@@ -11,7 +11,7 @@ public abstract class Activity : IActivity
     public string Id { get; set; } = default!;
     public string TypeName { get; set; }
     public bool CanStartWorkflow { get; set; }
-    public IDictionary<string, object> Metadata { get; set; } = new Dictionary<string, object>();
+    public IDictionary<string, object> ApplicationProperties { get; set; } = new Dictionary<string, object>();
 
     protected virtual ValueTask ExecuteAsync(ActivityExecutionContext context)
     {
diff --git a/src/core/Elsa.Management/Serialization/Converters/FlowchartJsonConverter.cs b/src/core/Elsa.Management/Serialization/Converters/FlowchartJsonConverter.cs
index 59daed67d..85f54300c 100644
--- a/src/core/Elsa.Management/Serialization/Converters/FlowchartJsonConverter.cs
+++ b/src/core/Elsa.Management/Serialization/Converters/FlowchartJsonConverter.cs
@@ -21,12 +21,12 @@ public class FlowchartJsonConverter : JsonConverter<Flowchart>
             throw new JsonException("Failed to parse JsonDocument");
 
         var connectionsElement = doc.RootElement.GetProperty("connections");
-        var metadataElement = doc.RootElement.GetProperty("metadata");
+        var applicationPropertiesElement = doc.RootElement.GetProperty("applicationProperties");
         var activitiesElement = doc.RootElement.GetProperty("activities");
         var id = doc.RootElement.GetProperty("id").GetString()!;
         var startId = doc.RootElement.TryGetProperty("start", out var startElement) ? startElement.GetString() : default;
         var rootActivities = activitiesElement.Deserialize<ICollection<IActivity>>(options) ?? new List<IActivity>();
-        var metadata = metadataElement.Deserialize<IDictionary<string, object>>(options) ?? new Dictionary<string, object>();
+        var applicationProperties = applicationPropertiesElement.Deserialize<IDictionary<string, object>>(options) ?? new Dictionary<string, object>();
         var start = rootActivities.FirstOrDefault(x => x.Id == startId) ?? rootActivities.FirstOrDefault();
         var connectionSerializerOptions = new JsonSerializerOptions(options);
         var activities = WalkActivityTree(rootActivities).ToList();
@@ -38,7 +38,7 @@ public class FlowchartJsonConverter : JsonConverter<Flowchart>
         return new Flowchart
         {
             Id = id,
-            Metadata = metadata,
+            ApplicationProperties = applicationProperties,
             Activities = rootActivities,
             Connections = connections,
             Start = start,
@@ -56,7 +56,7 @@ public class FlowchartJsonConverter : JsonConverter<Flowchart>
         {
             value.TypeName,
             value.Id,
-            value.Metadata,
+            value.ApplicationProperties,
             Start = value.Start?.Id,
             value.Activities,
             value.Connections