From 8d33084d4ee260e06db32c21fdc2f8844dc35cba Mon Sep 17 00:00:00 2001 From: Sipke Schoorstra Date: Sat, 10 Jun 2023 15:30:47 +0200 Subject: [PATCH] Fix null ID reference bug in function definition provider --- .../Providers/ActivityOutputFunctionsDefinitionProvider.cs | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/modules/Elsa.JavaScript/TypeDefinitions/Providers/ActivityOutputFunctionsDefinitionProvider.cs b/src/modules/Elsa.JavaScript/TypeDefinitions/Providers/ActivityOutputFunctionsDefinitionProvider.cs index bdb3e0e9e..a0d23fd1c 100644 --- a/src/modules/Elsa.JavaScript/TypeDefinitions/Providers/ActivityOutputFunctionsDefinitionProvider.cs +++ b/src/modules/Elsa.JavaScript/TypeDefinitions/Providers/ActivityOutputFunctionsDefinitionProvider.cs @@ -14,11 +14,13 @@ internal class ActivityOutputFunctionsDefinitionProvider : FunctionDefinitionPro { private readonly IActivityVisitor _activityVisitor; private readonly IActivityRegistry _activityRegistry; + private readonly IIdentityGraphService _identityGraphService; - public ActivityOutputFunctionsDefinitionProvider(IActivityVisitor activityVisitor, IActivityRegistry activityRegistry) + public ActivityOutputFunctionsDefinitionProvider(IActivityVisitor activityVisitor, IActivityRegistry activityRegistry, IIdentityGraphService identityGraphService) { _activityVisitor = activityVisitor; _activityRegistry = activityRegistry; + _identityGraphService = identityGraphService; } protected override async ValueTask> GetFunctionDefinitionsAsync(TypeDefinitionContext context) @@ -27,6 +29,8 @@ internal class ActivityOutputFunctionsDefinitionProvider : FunctionDefinitionPro var nodes = (await _activityVisitor.VisitAsync(context.Workflow.Root, context.CancellationToken)).Flatten().Distinct().ToList(); var activitiesWithOutputs = nodes.GetActivitiesWithOutputs(_activityRegistry); var definitions = new List(); + + _identityGraphService.AssignIdentities(nodes); foreach (var (activity, activityDescriptor) in activitiesWithOutputs) {