SemianiakaVY/elsa-core
1
0
Fork 0
Code Issues Pull requests Actions 1 Packages Projects Releases Wiki Activity

Fix loss of output

Browse source
This commit is contained in:
Sipke Schoorstra 2023-03-28 13:02:31 +02:00
parent f2dd77e37c
commit 877a65fe13
1 changed files with 8 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
src/modules/Elsa.Workflows.Management/Activities/WorkflowDefinitionActivity/WorkflowDefinitionActivity.cs
View file

@ -110,12 +110,14 @@ public class WorkflowDefinitionActivity : Composite, IInitializable
if (output == null)
return;
// If there's a block with the same name as the output property, we need to read its value and bind it against our output.
if (!context.ExpressionExecutionContext.Memory.HasBlock(outputDescriptor.Name))
continue;
var outputValue = context.ExpressionExecutionContext.Memory.Blocks[outputDescriptor.Name].Value;
context.Set(output, outputValue);
// @Herbert: this caused the variable from being overwritten with null.
// So to reproduce the bad behavior, uncomment these lines and run the test.
// if (!context.ExpressionExecutionContext.Memory.HasBlock(outputDescriptor.Name))
// continue;
//
// var outputValue = context.ExpressionExecutionContext.Memory.Blocks[outputDescriptor.Name].Value;
// context.Set(output, outputValue);
}
// Do we have a complete composite signal that triggered the completion?