From 7ad3da2c2aef25b1617ad2b7da2cbc23e96b1aa9 Mon Sep 17 00:00:00 2001 From: Sipke Schoorstra Date: Mon, 14 Aug 2023 14:47:35 +0200 Subject: [PATCH] Minor cleanup --- .../Elsa.Http/Scripting/JavaScript/HttpJavaScriptHandler.cs | 4 ++-- src/modules/Elsa.Http/Services/RouteMatcher.cs | 2 +- .../Elsa.JavaScript/Services/JintJavaScriptEvaluator.cs | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/modules/Elsa.Http/Scripting/JavaScript/HttpJavaScriptHandler.cs b/src/modules/Elsa.Http/Scripting/JavaScript/HttpJavaScriptHandler.cs index 969540af1..9d8732ad6 100644 --- a/src/modules/Elsa.Http/Scripting/JavaScript/HttpJavaScriptHandler.cs +++ b/src/modules/Elsa.Http/Scripting/JavaScript/HttpJavaScriptHandler.cs @@ -12,11 +12,11 @@ namespace Elsa.Http.Scripting.JavaScript; [PublicAPI] public class HttpJavaScriptHandler : INotificationHandler { - /// - public async Task HandleAsync(EvaluatingJavaScript notification, CancellationToken cancellationToken) + public Task HandleAsync(EvaluatingJavaScript notification, CancellationToken cancellationToken) { var engine = notification.Engine; engine.RegisterType(); + return Task.CompletedTask; } } \ No newline at end of file diff --git a/src/modules/Elsa.Http/Services/RouteMatcher.cs b/src/modules/Elsa.Http/Services/RouteMatcher.cs index eb24ce2a4..463662cf3 100644 --- a/src/modules/Elsa.Http/Services/RouteMatcher.cs +++ b/src/modules/Elsa.Http/Services/RouteMatcher.cs @@ -25,7 +25,7 @@ public class RouteMatcher : IRouteMatcher foreach (var parameter in parsedTemplate.Parameters) if (parameter.DefaultValue != null) - result.Add(parameter.Name, parameter.DefaultValue); + result.Add(parameter.Name!, parameter.DefaultValue); return result; } diff --git a/src/modules/Elsa.JavaScript/Services/JintJavaScriptEvaluator.cs b/src/modules/Elsa.JavaScript/Services/JintJavaScriptEvaluator.cs index 6e1250e85..4c8a26463 100644 --- a/src/modules/Elsa.JavaScript/Services/JintJavaScriptEvaluator.cs +++ b/src/modules/Elsa.JavaScript/Services/JintJavaScriptEvaluator.cs @@ -149,11 +149,11 @@ public class JintJavaScriptEvaluator : IJavaScriptEvaluator if (obj == null) return null!; - // If it's not an IEnumerable or it's a string or dictionary, return the original object + // If it's not an IEnumerable or it's a string or dictionary, return the original object. if (obj is not IEnumerable enumerable || obj is string || obj is IDictionary) return obj; - // Use LINQ to convert the IEnumerable to an array + // Use LINQ to convert the IEnumerable to an array. var elementType = obj.GetType().GetGenericArguments().FirstOrDefault(); if (elementType == null)