From 7560bfa756dd61b397779d356d8315cb90f66de3 Mon Sep 17 00:00:00 2001 From: Sipke Schoorstra Date: Fri, 2 Feb 2024 21:09:48 +0100 Subject: [PATCH] Improve error handling in JavaScript Evaluator Introduces a safeguard in the JintJavaScriptEvaluator in the Elsa.JavaScript module. This checks whether a workflow execution context can be retrieved before trying to get its input definitions. This prevents potential errors when the context isn't available. --- .../Elsa.JavaScript/Services/JintJavaScriptEvaluator.cs | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/modules/Elsa.JavaScript/Services/JintJavaScriptEvaluator.cs b/src/modules/Elsa.JavaScript/Services/JintJavaScriptEvaluator.cs index 56d38b6a0..557851197 100644 --- a/src/modules/Elsa.JavaScript/Services/JintJavaScriptEvaluator.cs +++ b/src/modules/Elsa.JavaScript/Services/JintJavaScriptEvaluator.cs @@ -132,7 +132,11 @@ public class JintJavaScriptEvaluator : IJavaScriptEvaluator return; var inputs = context.GetWorkflowInputs().ToDictionary(x => x.Name); - var inputDefinitions = context.GetWorkflowExecutionContext().Workflow.Inputs; + + if (!context.TryGetWorkflowExecutionContext(out var workflowExecutionContext)) + return; + + var inputDefinitions = workflowExecutionContext.Workflow.Inputs; foreach (var inputDefinition in inputDefinitions) {