From 63a2ec6000e6a92bb3702970e62c56a4944f3f54 Mon Sep 17 00:00:00 2001 From: Sipke Schoorstra Date: Mon, 31 May 2021 19:52:37 +0200 Subject: [PATCH] Prevent named activities from being rendered into typescript definition when name is empty string --- .../Handlers/ConfigureJavaScriptEngine.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/scripting/Elsa.Scripting.JavaScript/Handlers/ConfigureJavaScriptEngine.cs b/src/scripting/Elsa.Scripting.JavaScript/Handlers/ConfigureJavaScriptEngine.cs index 05c67501f..03bcf1193 100644 --- a/src/scripting/Elsa.Scripting.JavaScript/Handlers/ConfigureJavaScriptEngine.cs +++ b/src/scripting/Elsa.Scripting.JavaScript/Handlers/ConfigureJavaScriptEngine.cs @@ -91,7 +91,7 @@ namespace Elsa.Scripting.JavaScript.Handlers } // Named activities. - foreach (var activity in workflowBlueprint.Activities.Where(x => x.Name is not null)) + foreach (var activity in workflowBlueprint.Activities.Where(x => !string.IsNullOrWhiteSpace(x.Name))) { var state = activityExecutionContext.GetActivityData(activity.Id); var dictionary = state.ToDictionary(); @@ -150,7 +150,7 @@ namespace Elsa.Scripting.JavaScript.Handlers } // Named Activities. - var namedActivities = workflowDefinition.Activities.Where(x => x.Name is not null).ToList(); + var namedActivities = workflowDefinition.Activities.Where(x => !string.IsNullOrWhiteSpace(x.Name)).ToList(); var activityTypeNames = namedActivities.Select(x => x.Type).Distinct().ToList(); var activityTypes = await Task.WhenAll(activityTypeNames.Select(async activityTypeName => (activityTypeName, await _activityTypeService.GetActivityTypeAsync(activityTypeName, cancellationToken)))); var activityTypeDictionary = activityTypes.ToDictionary(x => x.activityTypeName, x => x.Item2);