SemianiakaVY/elsa-core
1
0
Fork 0
Code Issues Pull requests Actions 1 Packages Projects Releases Wiki Activity

Fix structured log write buffer shutdown flush (#7460)

Browse source 
* Fix structured log write buffer shutdown flush

* Address structured log buffer review feedback
This commit is contained in:
Sipke Schoorstra 2026-05-17 19:33:29 +02:00 committed by GitHub
parent 8416ea8af4
commit 60e742b0e3
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 10 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
src/modules/Elsa.Diagnostics.StructuredLogs.Persistence.Relational/Services/StructuredLogWriteBuffer.cs
View file

@ -149,17 +149,18 @@ public class StructuredLogWriteBuffer(
private async Task ProcessQueueAsync()
{
using var timer = new PeriodicTimer(options.Value.WriteQueue.FlushInterval);
var cancellationToken = _stopTokenSource.Token;
while (!cancellationToken.IsCancellationRequested)
{
try
{
var signalTask = _signal.WaitAsync(cancellationToken);
var timerTask = timer.WaitForNextTickAsync(cancellationToken).AsTask();
await Task.WhenAny(signalTask, timerTask);
await FlushAsync(cancellationToken);
await _signal.WaitAsync(options.Value.WriteQueue.FlushInterval, cancellationToken);
if (cancellationToken.IsCancellationRequested)
return;
await FlushAsync();
}
catch (OperationCanceledException) when (cancellationToken.IsCancellationRequested)
{
@ -169,9 +170,12 @@ public class StructuredLogWriteBuffer(
{
return;
}
catch (Exception e) when (!cancellationToken.IsCancellationRequested)
catch (Exception e)
{
Trace.TraceError("Failed to flush structured log writes: {0}", e);
if (cancellationToken.IsCancellationRequested)
return;
}
}
}