SemianiakaVY/elsa-core
1
0
Fork 0
Code Issues Pull requests Actions 1 Packages Projects Releases Wiki Activity

Refactor workflow graph retrieval logic.

Browse source 
Extract shared workflow graph retrieval logic into a new `GetWorkflowGraphAsync` method, reducing code duplication. Updated call sites to use the new method for better maintainability and readability.
This commit is contained in:
Sipke Schoorstra 2025-01-10 10:07:54 +01:00
parent ada9f3967e
commit 605a46fdf7
1 changed files with 10 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
src/modules/Elsa.Workflows.Runtime/Services/LocalWorkflowClient.cs
View file

@ -29,8 +29,7 @@ public class LocalWorkflowClient(
public async Task<CreateWorkflowInstanceResponse> CreateInstanceAsync(CreateWorkflowInstanceRequest request, CancellationToken cancellationToken = default)
{
var workflowDefinitionHandle = request.WorkflowDefinitionHandle;
var workflowGraph = await workflowDefinitionService.FindWorkflowGraphAsync(workflowDefinitionHandle, cancellationToken);
if (workflowGraph == null) throw new InvalidOperationException($"Workflow with version ID {workflowDefinitionHandle} not found.");
var workflowGraph = await GetWorkflowGraphAsync(workflowDefinitionHandle, cancellationToken);
var options = new WorkflowInstanceOptions
{
@ -138,8 +137,7 @@ public class LocalWorkflowClient(
public async Task<WorkflowInstance> CreateInstanceInternalAsync(CreateWorkflowInstanceRequest request, CancellationToken cancellationToken = default)
{
var workflowDefinitionHandle = request.WorkflowDefinitionHandle;
var workflowGraph = await workflowDefinitionService.FindWorkflowGraphAsync(workflowDefinitionHandle, cancellationToken);
if (workflowGraph == null) throw new InvalidOperationException($"Workflow with version ID {workflowDefinitionHandle} not found.");
var workflowGraph = await GetWorkflowGraphAsync(workflowDefinitionHandle, cancellationToken);
var options = new WorkflowInstanceOptions
{
@ -162,8 +160,14 @@ public class LocalWorkflowClient(
private async Task<WorkflowGraph> GetWorkflowGraphAsync(WorkflowInstance workflowInstance, CancellationToken cancellationToken)
{
var workflowGraph = await workflowDefinitionService.FindWorkflowGraphAsync(workflowInstance.DefinitionVersionId, cancellationToken);
if (workflowGraph == null) throw new InvalidOperationException($"Workflow graph with version ID {workflowInstance.DefinitionVersionId} not found.");
var handle = WorkflowDefinitionHandle.ByDefinitionVersionId(workflowInstance.DefinitionVersionId);
return await GetWorkflowGraphAsync(handle, cancellationToken);
}
private async Task<WorkflowGraph> GetWorkflowGraphAsync(WorkflowDefinitionHandle definitionHandle, CancellationToken cancellationToken)
{
var workflowGraph = await workflowDefinitionService.FindWorkflowGraphAsync(definitionHandle, cancellationToken);
if (workflowGraph == null) throw new InvalidOperationException($"Workflow graph with handle {definitionHandle} not found.");
return workflowGraph;
}
}