From 427784ec3be3b0628deb6dcd45f29fb2f5fca0ba Mon Sep 17 00:00:00 2001
From: Sipke Schoorstra <sipkeschoorstra@outlook.com>
Date: Tue, 26 Jul 2022 16:01:10 +0200
Subject: [PATCH] Small HTTP response improvements

---
 src/bundles/Elsa.WorkflowServer.Web/Program.cs         |  1 +
 .../icons/activities/write-http-response.tsx           | 10 ++++++++++
 .../src/services/activity-icon-registry.tsx            |  2 ++
 src/modules/Elsa.Http/Activities/WriteHttpResponse.cs  |  2 +-
 .../Attributes/ActivityAttribute.cs                    | 10 +++++-----
 5 files changed, 19 insertions(+), 6 deletions(-)
 create mode 100644 src/designer/elsa-workflows-designer/src/components/icons/activities/write-http-response.tsx

diff --git a/src/bundles/Elsa.WorkflowServer.Web/Program.cs b/src/bundles/Elsa.WorkflowServer.Web/Program.cs
index 7bc071e4d..c317db5ef 100644
--- a/src/bundles/Elsa.WorkflowServer.Web/Program.cs
+++ b/src/bundles/Elsa.WorkflowServer.Web/Program.cs
@@ -57,6 +57,7 @@ services
             .AddActivity<ReadLine>()
             .AddActivity<If>()
             .AddActivity<HttpEndpoint>()
+            .AddActivity<WriteHttpResponse>()
             .AddActivity<Flowchart>()
             .AddActivity<FlowDecision>()
             .AddActivity<FlowSwitch>()
diff --git a/src/designer/elsa-workflows-designer/src/components/icons/activities/write-http-response.tsx b/src/designer/elsa-workflows-designer/src/components/icons/activities/write-http-response.tsx
new file mode 100644
index 000000000..3de5a549e
--- /dev/null
+++ b/src/designer/elsa-workflows-designer/src/components/icons/activities/write-http-response.tsx
@@ -0,0 +1,10 @@
+import {FunctionalComponent, h} from '@stencil/core';
+import {ActivityIconSettings, getActivityIconCssClass} from "./models";
+
+export const WriteHttpResponseIcon: FunctionalComponent<ActivityIconSettings> = (settings) => (
+  <svg class={getActivityIconCssClass(settings)} width="24" height="24" viewBox="0 0 24 24"
+       stroke-width="2"
+       stroke="currentColor" fill="none" stroke-linecap="round" stroke-linejoin="round">
+    <path stroke-linecap="round" stroke-linejoin="round" stroke-width="2" d="M11 5H6a2 2 0 00-2 2v11a2 2 0 002 2h11a2 2 0 002-2v-5m-1.414-9.414a2 2 0 112.828 2.828L11.828 15H9v-2.828l8.586-8.586z"/>
+  </svg>
+);
diff --git a/src/designer/elsa-workflows-designer/src/services/activity-icon-registry.tsx b/src/designer/elsa-workflows-designer/src/services/activity-icon-registry.tsx
index ac6896495..d913aa172 100644
--- a/src/designer/elsa-workflows-designer/src/services/activity-icon-registry.tsx
+++ b/src/designer/elsa-workflows-designer/src/services/activity-icon-registry.tsx
@@ -14,6 +14,7 @@ import {
   TimerIcon,
   WriteLineIcon
 } from "../components/icons/activities";
+import {WriteHttpResponseIcon} from "../components/icons/activities/write-http-response";
 
 export type ActivityType = string;
 export type ActivityIcon = (ActivityIconSettings?) => any;
@@ -29,6 +30,7 @@ export class ActivityIconRegistry {
     this.add('Elsa.If', settings => <IfIcon size={settings?.size}/>);
     this.add('Elsa.Flowchart', settings => <FlowchartIcon size={settings?.size}/>);
     this.add('Elsa.HttpEndpoint', settings => <HttpEndpointIcon size={settings?.size}/>);
+    this.add('Elsa.WriteHttpResponse', settings => <WriteHttpResponseIcon size={settings?.size}/>);
     this.add('Elsa.ForEach', settings => <ForEachIcon size={settings?.size}/>);
     this.add('Elsa.Delay', settings => <DelayIcon size={settings?.size}/>);
     this.add('Elsa.Timer', settings => <TimerIcon size={settings?.size}/>);
diff --git a/src/modules/Elsa.Http/Activities/WriteHttpResponse.cs b/src/modules/Elsa.Http/Activities/WriteHttpResponse.cs
index b54e5a10a..7a76135b7 100644
--- a/src/modules/Elsa.Http/Activities/WriteHttpResponse.cs
+++ b/src/modules/Elsa.Http/Activities/WriteHttpResponse.cs
@@ -6,7 +6,7 @@ using Microsoft.AspNetCore.Http;
 
 namespace Elsa.Http;
 
-[Activity("Elsa", "HTTP", "Write an HTTP response.")]
+[Activity("Elsa", "HTTP", "Write an HTTP response.", DisplayName = "HTTP Response")]
 public class WriteHttpResponse : Activity
 {
     public Input<HttpStatusCode> StatusCode { get; set; } = new(HttpStatusCode.OK);
diff --git a/src/modules/Elsa.Workflows.Core/Attributes/ActivityAttribute.cs b/src/modules/Elsa.Workflows.Core/Attributes/ActivityAttribute.cs
index 9f6f3a7ce..ccb3c0e5e 100644
--- a/src/modules/Elsa.Workflows.Core/Attributes/ActivityAttribute.cs
+++ b/src/modules/Elsa.Workflows.Core/Attributes/ActivityAttribute.cs
@@ -25,9 +25,9 @@ public class ActivityAttribute : Attribute
         Category = category;
     }
 
-    public string? Namespace { get; }
-    public string? TypeName { get; }
-    public string? Description { get; }
-    public string? DisplayName { get; }
-    public string? Category { get; }
+    public string? Namespace { get; set;}
+    public string? TypeName { get; set;}
+    public string? Description { get; set;}
+    public string? DisplayName { get; set; }
+    public string? Category { get; set;}
 }
\ No newline at end of file