From 3b304c8e0856a96fbc196afda1052f4593cb1d43 Mon Sep 17 00:00:00 2001 From: Sipke Schoorstra Date: Wed, 24 Jul 2024 14:14:50 +0200 Subject: [PATCH] Add OnStopped method to dispose of _linkedTokenSource This commit introduces the OnStopped method in the WorkflowInstanceImpl class to properly dispose of _linkedTokenSource. This change ensures that resources are appropriately cleaned up when the actor is stopped, preventing potential memory leaks. --- .../Actors/WorkflowInstanceImpl.cs | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/modules/Elsa.Workflows.Runtime.ProtoActor/Actors/WorkflowInstanceImpl.cs b/src/modules/Elsa.Workflows.Runtime.ProtoActor/Actors/WorkflowInstanceImpl.cs index 6b37bd907..d85b38f45 100644 --- a/src/modules/Elsa.Workflows.Runtime.ProtoActor/Actors/WorkflowInstanceImpl.cs +++ b/src/modules/Elsa.Workflows.Runtime.ProtoActor/Actors/WorkflowInstanceImpl.cs @@ -47,6 +47,12 @@ internal class WorkflowInstanceImpl( return Task.CompletedTask; } + public override Task OnStopped() + { + _linkedTokenSource.Dispose(); + return Task.CompletedTask; + } + public override Task Create(ProtoCreateWorkflowInstanceRequest request) => throw new NotImplementedException(); public override Task Create(ProtoCreateWorkflowInstanceRequest request, Action respond, Action onError)