From 302292255c84d7a1949ef97afb95d9bc5baeb479 Mon Sep 17 00:00:00 2001
From: Raymond den Haan <raymond.den.haan@nexxbiz.io>
Date: Tue, 20 Aug 2024 12:37:48 +0200
Subject: [PATCH] Introduce UniqueKeyConstraintViolationException

Refactor DataProcessingException to remove unique key logic and create a dedicated UniqueKeyConstraintViolationException. Update DbExceptionTransformer to use the new exception for unique key violations, improving code clarity and separation of concerns.
---
 .../Handlers/DbExceptionTransformer.cs                      | 5 +++--
 .../Exceptions/DataProcessingException.cs                   | 6 +-----
 .../Exceptions/UniqueKeyConstraintViolationException.cs     | 4 ++++
 3 files changed, 8 insertions(+), 7 deletions(-)
 create mode 100644 src/modules/Elsa.Workflows.Core/Exceptions/UniqueKeyConstraintViolationException.cs

diff --git a/src/modules/Elsa.EntityFrameworkCore.PostgreSql/Handlers/DbExceptionTransformer.cs b/src/modules/Elsa.EntityFrameworkCore.PostgreSql/Handlers/DbExceptionTransformer.cs
index b822bc3e8..cca8723af 100644
--- a/src/modules/Elsa.EntityFrameworkCore.PostgreSql/Handlers/DbExceptionTransformer.cs
+++ b/src/modules/Elsa.EntityFrameworkCore.PostgreSql/Handlers/DbExceptionTransformer.cs
@@ -20,8 +20,9 @@ public class DbExceptionTransformer : IDbExceptionHandler<AlterationsElsaDbConte
     /// Transforms database exceptions encountered when using a postgreSQL database into more generic exceptions.
     public void Handle(DbUpdateException exception)
     {
-        var ex = exception.InnerException as PostgresException;
+        if (exception.InnerException is PostgresException { SqlState: "23505" })
+            throw new UniqueKeyConstraintViolationException("Unable to save data", exception);
 
-        throw new DataProcessingException(ex?.SqlState == "23505", "Unable to save data", exception);
+        throw new DataProcessingException("Unable to save data", exception);
     }
 }
\ No newline at end of file
diff --git a/src/modules/Elsa.Workflows.Core/Exceptions/DataProcessingException.cs b/src/modules/Elsa.Workflows.Core/Exceptions/DataProcessingException.cs
index 2af7ab1e2..ddd2676a7 100644
--- a/src/modules/Elsa.Workflows.Core/Exceptions/DataProcessingException.cs
+++ b/src/modules/Elsa.Workflows.Core/Exceptions/DataProcessingException.cs
@@ -1,8 +1,4 @@
 namespace Elsa.Workflows.Exceptions;
 
 /// An exception that occurs during data processing.
-public class DataProcessingException(bool isUkViolation, string message, Exception exception) : Exception(message, exception)
-{
-    /// Gets a value indicating whether the exception is a Unique Key violation.
-    public bool IsUkViolation { get; } = isUkViolation;
-}
+public class DataProcessingException(string message, Exception exception) : Exception(message, exception);
diff --git a/src/modules/Elsa.Workflows.Core/Exceptions/UniqueKeyConstraintViolationException.cs b/src/modules/Elsa.Workflows.Core/Exceptions/UniqueKeyConstraintViolationException.cs
new file mode 100644
index 000000000..26f87ff5e
--- /dev/null
+++ b/src/modules/Elsa.Workflows.Core/Exceptions/UniqueKeyConstraintViolationException.cs
@@ -0,0 +1,4 @@
+namespace Elsa.Workflows.Exceptions;
+
+/// An exception that when a unique key constraint has been violated.
+public class UniqueKeyConstraintViolationException(string message, Exception exception) : Exception(message, exception);