From 2f6e579cb359978601cb5d7df04bf39dc20d042f Mon Sep 17 00:00:00 2001
From: Robin Sue <robinsue@live.de>
Date: Tue, 2 Apr 2024 15:17:25 +0200
Subject: [PATCH] Use PolySharp for automatic polyfilling (#5161)

* Remove unnecessary whitespace in packages.yml

The whitespace after the if conditional in packages.yml was unused and unnecessary. This commit ensures to remove those to promote cleaner, more efficient code.

* Update default package version in GitHub workflows

The package version in the GitHub workflows configuration (.github/workflows/packages.yml) has been updated from 3.1.0 to 3.2.0. This change reflects version updates in the package management system.

* Use PolySharp for automatic polyfilling

PolySharp is a design time only dependency which will analyze which polyfills are needed for the currently building target framework and will then source generate only the needed polyfills. Also they're internal by default so they don't conflict.

fixes #5157

---------

Co-authored-by: Sipke Schoorstra <sipkeschoorstra@outlook.com>
---
 Directory.Packages.props                                  | 1 +
 .../Elsa.Workflows.Management.csproj                      | 6 +++++-
 src/modules/Elsa.Workflows.Management/RequiredMembers.cs  | 8 --------
 3 files changed, 6 insertions(+), 9 deletions(-)
 delete mode 100644 src/modules/Elsa.Workflows.Management/RequiredMembers.cs

diff --git a/Directory.Packages.props b/Directory.Packages.props
index a03b4408d..759b7d2e1 100644
--- a/Directory.Packages.props
+++ b/Directory.Packages.props
@@ -66,6 +66,7 @@
         <PackageVersion Include="Nuke.Components" Version="8.0.0"/>
         <PackageVersion Include="Open.Linq.AsyncExtensions" Version="1.2.0"/>
         <PackageVersion Include="Polly.Extensions.Http" Version="3.0.0"/>
+        <PackageVersion Include="PolySharp" Version="1.14.1"/>
         <PackageVersion Include="Proto.Actor" Version="1.5.0"/>
         <PackageVersion Include="Proto.Cluster" Version="1.5.0"/>
         <PackageVersion Include="Proto.Cluster.CodeGen" Version="1.5.0"/>
diff --git a/src/modules/Elsa.Workflows.Management/Elsa.Workflows.Management.csproj b/src/modules/Elsa.Workflows.Management/Elsa.Workflows.Management.csproj
index e4baba018..e85092fbb 100644
--- a/src/modules/Elsa.Workflows.Management/Elsa.Workflows.Management.csproj
+++ b/src/modules/Elsa.Workflows.Management/Elsa.Workflows.Management.csproj
@@ -1,4 +1,4 @@
-<Project Sdk="Microsoft.NET.Sdk">
+<Project Sdk="Microsoft.NET.Sdk">
 
     <PropertyGroup>
         <Description>
@@ -10,6 +10,10 @@
     <ItemGroup>
         <PackageReference Include="Humanizer.Core" />
         <PackageReference Include="IronCompress" />
+        <PackageReference Include="PolySharp">
+          <PrivateAssets>all</PrivateAssets>
+          <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+        </PackageReference>
         <PackageReference Include="System.Linq.Dynamic.Core" />
     </ItemGroup>
 
diff --git a/src/modules/Elsa.Workflows.Management/RequiredMembers.cs b/src/modules/Elsa.Workflows.Management/RequiredMembers.cs
deleted file mode 100644
index e1a4aad6d..000000000
--- a/src/modules/Elsa.Workflows.Management/RequiredMembers.cs
+++ /dev/null
@@ -1,8 +0,0 @@
-// See: https://github.com/dotnet/core/issues/8016
-namespace System.Runtime.CompilerServices;
-
-public class RequiredMemberAttribute : Attribute { }
-public class CompilerFeatureRequiredAttribute : Attribute
-{
-    public CompilerFeatureRequiredAttribute(string name) { }
-}
\ No newline at end of file