From 2d5511dfbcafa0c3585d867d06d9da5462e8c49b Mon Sep 17 00:00:00 2001 From: Sipke Schoorstra Date: Sat, 5 Dec 2020 12:06:23 +0100 Subject: [PATCH] Skip scheduling if timeout is zero (i.e. execute immediately) --- .../Elsa.Activities.Timers/Activities/Timer/Timer.cs | 3 +++ src/core/Elsa.Abstractions/Services/Models/ProcessFault.cs | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/src/activities/Elsa.Activities.Timers/Activities/Timer/Timer.cs b/src/activities/Elsa.Activities.Timers/Activities/Timer/Timer.cs index 84afe2c02..6ba87a039 100644 --- a/src/activities/Elsa.Activities.Timers/Activities/Timer/Timer.cs +++ b/src/activities/Elsa.Activities.Timers/Activities/Timer/Timer.cs @@ -31,6 +31,9 @@ namespace Elsa.Activities.Timers { if (context.WorkflowExecutionContext.IsFirstPass) return Done(); + + if (Timeout == Duration.Zero) + return Done(); ExecuteAt = _clock.GetCurrentInstant().Plus(Timeout); diff --git a/src/core/Elsa.Abstractions/Services/Models/ProcessFault.cs b/src/core/Elsa.Abstractions/Services/Models/ProcessFault.cs index c23211cec..d102059fc 100644 --- a/src/core/Elsa.Abstractions/Services/Models/ProcessFault.cs +++ b/src/core/Elsa.Abstractions/Services/Models/ProcessFault.cs @@ -13,7 +13,7 @@ public Elsa.Models.WorkflowFault ToInstance() { - return new Elsa.Models.WorkflowFault + return new() { FaultedActivityId = FaultedActivity?.Id, Message = Message