From 2cbcefee836acd2c1b805be82543eb69f9acfa4f Mon Sep 17 00:00:00 2001 From: Sipke Schoorstra Date: Sat, 14 Jun 2025 12:15:34 +0200 Subject: [PATCH] Remove `HealActivity` alteration and handler - Deleted `HealActivity` alteration type and associated `HealActivityHandler`. - Unregistered `HealActivity` from alteration services. --- .../AlterationHandlers/HealActivityHandler.cs | 42 ------------------- .../AlterationTypes/HealActivity.cs | 17 -------- .../Extensions/ServiceCollectionExtensions.cs | 1 - 3 files changed, 60 deletions(-) delete mode 100644 src/modules/Elsa.Alterations/AlterationHandlers/HealActivityHandler.cs delete mode 100644 src/modules/Elsa.Alterations/AlterationTypes/HealActivity.cs diff --git a/src/modules/Elsa.Alterations/AlterationHandlers/HealActivityHandler.cs b/src/modules/Elsa.Alterations/AlterationHandlers/HealActivityHandler.cs deleted file mode 100644 index 715380a3d..000000000 --- a/src/modules/Elsa.Alterations/AlterationHandlers/HealActivityHandler.cs +++ /dev/null @@ -1,42 +0,0 @@ -using Elsa.Alterations.AlterationTypes; -using Elsa.Alterations.Core.Abstractions; -using Elsa.Alterations.Core.Contexts; -using Elsa.Extensions; -using Elsa.Workflows; -using JetBrains.Annotations; - -namespace Elsa.Alterations.AlterationHandlers; - -/// -/// Cancels an activity. -/// -[UsedImplicitly] -public class HealActivityHandler : AlterationHandlerBase -{ - /// - protected override ValueTask HandleAsync(AlterationContext context, HealActivity alteration) - { - var activityExecutionContexts = context.WorkflowExecutionContext.FindActivityExecutionContexts(alteration.ActivityHandle).ToList(); - - if (!activityExecutionContexts.Any()) - { - context.Fail($"Activity execution context with handle {alteration.ActivityHandle} not found"); - - return ValueTask.CompletedTask; - } - - context.Succeed(() => Heal(activityExecutionContexts)); - return ValueTask.CompletedTask; - } - - private void Heal(IEnumerable activityExecutionContexts) - { - foreach (var activityExecutionContext in activityExecutionContexts) - Heal(activityExecutionContext); - } - - private void Heal(ActivityExecutionContext activityExecutionContext) - { - activityExecutionContext.RecoverFromFault(); - } -} \ No newline at end of file diff --git a/src/modules/Elsa.Alterations/AlterationTypes/HealActivity.cs b/src/modules/Elsa.Alterations/AlterationTypes/HealActivity.cs deleted file mode 100644 index 1afbdb8d0..000000000 --- a/src/modules/Elsa.Alterations/AlterationTypes/HealActivity.cs +++ /dev/null @@ -1,17 +0,0 @@ -using Elsa.Alterations.Core.Abstractions; -using Elsa.Workflows.Models; -using JetBrains.Annotations; - -namespace Elsa.Alterations.AlterationTypes; - -/// -/// Heals an activity from the Faulted state. -/// -[UsedImplicitly] -public class HealActivity : AlterationBase -{ - /// - /// The handle to the to be healed. - /// - public ActivityHandle ActivityHandle { get; set; } = null!; -} \ No newline at end of file diff --git a/src/modules/Elsa.Alterations/Extensions/ServiceCollectionExtensions.cs b/src/modules/Elsa.Alterations/Extensions/ServiceCollectionExtensions.cs index 5f2c069f1..b930d2878 100644 --- a/src/modules/Elsa.Alterations/Extensions/ServiceCollectionExtensions.cs +++ b/src/modules/Elsa.Alterations/Extensions/ServiceCollectionExtensions.cs @@ -20,7 +20,6 @@ public static class ServiceCollectionExtensions services.AddAlteration(); services.AddAlteration(); services.AddAlteration(); - services.AddAlteration(); services.AddAlteration(); services.AddNotificationHandlersFrom(); return services;