SemianiakaVY/elsa-core
1
0
Fork 0
Code Issues Pull requests Actions 1 Packages Projects Releases Wiki Activity

Fixed IsNameUnique for InMemory WorkflowDefinition store (#4370)

Browse source
This commit is contained in:
yspanj 2023-08-29 23:29:57 +02:00 committed by GitHub
parent e2c3ab0efd
commit 2c014a9524
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 9 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/modules/Elsa.Dapper/Modules/Management/Services/DapperWorkflowDefinitionStore.cs
View file

@ -154,13 +154,15 @@ public class DapperWorkflowDefinitionStore : IWorkflowDefinitionStore
/// <inheritdoc />
public async Task<bool> GetIsNameUnique(string name, string? definitionId = default, CancellationToken cancellationToken = default)
{
return await _store.AnyAsync(query =>
var exists = await _store.AnyAsync(query =>
{
query.Is(nameof(WorkflowDefinition.Name), name);
if (definitionId != null)
query.IsNot(nameof(WorkflowDefinition.DefinitionId), definitionId);
}, cancellationToken);
return !exists;
}
private void ApplyFilter(ParameterizedQuery query, WorkflowDefinitionFilter filter)

3
src/modules/Elsa.EntityFrameworkCore/Modules/Management/WorkflowDefinitionStore.cs
View file

@ -146,7 +146,8 @@ public class EFCoreWorkflowDefinitionStore : IWorkflowDefinitionStore
/// <inheritdoc />
public async Task<bool> GetIsNameUnique(string name, string? definitionId = default, CancellationToken cancellationToken = default)
{
return await _store.AnyAsync(x => x.Name == name && x.DefinitionId != definitionId, cancellationToken);
var exists = await _store.AnyAsync(x => x.Name == name && x.DefinitionId != definitionId, cancellationToken);
return !exists;
}
private ValueTask OnSaveAsync(ManagementElsaDbContext managementElsaDbContext, WorkflowDefinition entity, CancellationToken cancellationToken)

3
src/modules/Elsa.MongoDb/Modules/Management/WorkflowDefinitionStore.cs
View file

@ -132,7 +132,8 @@ public class MongoWorkflowDefinitionStore : IWorkflowDefinitionStore
/// <inheritdoc />
public async Task<bool> GetIsNameUnique(string name, string? definitionId = default, CancellationToken cancellationToken = default)
{
return await _mongoDbStore.AnyAsync(x => x.Name == name && x.DefinitionId != definitionId, cancellationToken);
var exists = await _mongoDbStore.AnyAsync(x => x.Name == name && x.DefinitionId != definitionId, cancellationToken);
return !exists;
}
private IMongoQueryable<WorkflowDefinition> Filter(IMongoQueryable<WorkflowDefinition> queryable, WorkflowDefinitionFilter filter) =>

4
src/modules/Elsa.Workflows.Api/Endpoints/WorkflowDefinitions/IsNameUnique/Endpoint.cs
View file

@ -25,8 +25,8 @@ internal class IsNameUnique : ElsaEndpoint<Request>
public override async Task HandleAsync(Request request, CancellationToken cancellationToken)
{
var exists = await _store.GetIsNameUnique(request.Name.Trim(), request.DefinitionId, cancellationToken);
var response = new Response(!exists);
var isUnique = await _store.GetIsNameUnique(request.Name.Trim(), request.DefinitionId, cancellationToken);
var response = new Response(isUnique);
await SendOkAsync(response, cancellationToken);
}