SemianiakaVY/elsa-core
1
0
Fork 0
Code Issues Pull requests Actions 1 Packages Projects Releases Wiki Activity

Update NotFoundActivity display text + description (#4578)

Browse source
This commit is contained in:
Sipke Schoorstra 2023-10-26 14:37:18 +02:00 committed by GitHub
parent 02ec4c2391
commit 2b34f1d72c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 26 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
src/modules/Elsa.Workflows.Core/Extensions/ActivityPropertyExtensions.cs
View file

@ -26,15 +26,15 @@ public static class ActivityPropertyExtensions
/// <summary>
/// Gets a flag indicating if this activity should execute synchronously or asynchronously.
/// By default, activities with an <see cref="Workflows.Core.Models.ActivityKind"/> of <see cref="Action"/>, <see cref="Task"/> or <see cref="Trigger"/>
/// will execute synchronously, while activities of the <see cref="Workflows.Core.Models.ActivityKind.Job"/> kind will execute asynchronously.
/// By default, activities with an <see cref="ActivityKind"/> of <see cref="Action"/>, <see cref="Task"/> or <see cref="Trigger"/>
/// will execute synchronously, while activities of the <see cref="ActivityKind.Job"/> kind will execute asynchronously.
/// </summary>
public static bool GetRunAsynchronously(this IActivity activity) => activity.CustomProperties.GetValueOrDefault(RunAsynchronouslyPropertyName, () => false);
/// <summary>
/// Sets a flag indicating if this activity should execute synchronously or asynchronously.
/// By default, activities with an <see cref="Workflows.Core.Models.ActivityKind"/> of <see cref="Action"/>, <see cref="Task"/> or <see cref="Trigger"/>
/// will execute synchronously, while activities of the <see cref="Workflows.Core.Models.ActivityKind.Job"/> kind will execute asynchronously.
/// By default, activities with an <see cref="ActivityKind"/> of <see cref="Action"/>, <see cref="Task"/> or <see cref="Trigger"/>
/// will execute synchronously, while activities of the <see cref="ActivityKind.Job"/> kind will execute asynchronously.
/// </summary>
public static void SetRunAsynchronously(this IActivity activity, bool value) => activity.CustomProperties[RunAsynchronouslyPropertyName[0]] = value;
@ -59,4 +59,24 @@ public static class ActivityPropertyExtensions
var source = $"{Path.GetFileName(sourceFile)}:{lineNumber}";
activity.SetSource(source);
}
/// <summary>
/// Gets the display text for the specified activity.
/// </summary>
public static string? GetDisplayText(this IActivity activity) => activity.Metadata.TryGetValue("displayText", out var value) ? value.ToString() : default;
/// <summary>
/// Sets the display text for the specified activity.
/// </summary>
public static void SetDisplayText(this IActivity activity, string value) => activity.Metadata["displayText"] = value;
/// <summary>
/// Gets the description for the specified activity.
/// </summary>
public static string? GetDescription(this IActivity activity) => activity.Metadata.TryGetValue("description", out var value) ? value.ToString() : default;
/// <summary>
/// Sets the description for the specified activity.
/// </summary>
public static void SetDescription(this IActivity activity, string value) => activity.Metadata["description"] = value;
}

2
src/modules/Elsa.Workflows.Management/Serialization/Converters/ActivityJsonConverter.cs
View file

@ -72,6 +72,8 @@ public class ActivityJsonConverter : JsonConverter<IActivity>
notFoundActivity.MissingTypeName = activityTypeName;
notFoundActivity.MissingTypeVersion = activityTypeVersion;
notFoundActivity.OriginalActivityJson = activityRoot.ToString();
notFoundActivity.SetDisplayText($"Not Found: {activityTypeName}");
notFoundActivity.SetDescription($"Could not find activity type {activityTypeName} with version {activityTypeVersion}");
return notFoundActivity;
}