SemianiakaVY/elsa-core
1
0
Fork 0
Code Issues Pull requests Actions 1 Packages Projects Releases Wiki Activity

Prevent duplicate rendering of activities with multiple ancestor inbound connections

Browse source
This commit is contained in:
Sipke Schoorstra 2021-04-14 14:38:14 +02:00
parent a50f30203c
commit 2902569d8f
1 changed files with 18 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

29
src/designer/elsa-workflows-studio/src/components/designers/tree/elsa-designer-tree/elsa-designer-tree.tsx
View file

@ -96,7 +96,7 @@ export class ElsaWorkflowDesigner {
eventBus.emit(EventTypes.ActivityDesignDisplaying, this, displayContext);
displayContexts[model.activityId] = displayContext;
}
this.activityDisplayContexts = displayContexts;
}
@ -106,15 +106,17 @@ export class ElsaWorkflowDesigner {
const sourceEndpoints = this.getJsPlumbSourceEndpoints();
const targets = this.getJsPlumbTargets();
const invalidConnections = updateConnections(
canvasElement,
connections,
sourceEndpoints,
targets,
connection => this.onConnectionCreated(connection),
connection => this.onConnectionDetached(connection));
setTimeout(() => {
const invalidConnections = updateConnections(
canvasElement,
connections,
sourceEndpoints,
targets,
connection => this.onConnectionCreated(connection),
connection => this.onConnectionDetached(connection));
this.removeInvalidConnections(invalidConnections);
this.removeInvalidConnections(invalidConnections);
}, 100)
}
showActivityPicker() {
@ -431,8 +433,8 @@ export class ElsaWorkflowDesigner {
const list = activities.filter(x => !renderedActivities.has(x.activityId));
const cssClass = isRoot ? "root" : undefined;
for (const activity of list)
renderedActivities.add(activity.activityId);
// for (const activity of list)
// renderedActivities.add(activity.activityId);
if (list.length == 0)
return null;
@ -444,6 +446,11 @@ export class ElsaWorkflowDesigner {
const children = getChildActivities(this.workflowModel, activityId);
const displayContext = this.activityDisplayContexts[activityId];
if(renderedActivities.has(displayContext.activityModel.activityId))
return;
renderedActivities.add(displayContext.activityModel.activityId);
return <li key={x.activityId}>
<div class="inline-flex flex flex-col items-center">
{isRoot ? this.renderOutcomeButton(`start-button-plus-${x.activityId}`, '', activityId, e => this.onOutcomeButtonClick(e, null, activityId)) : undefined}