SemianiakaVY/elsa-core
1
0
Fork 0
Code Issues Pull requests Actions 1 Packages Projects Releases Wiki Activity

Fix inconsistent input IDs

Browse source
This commit is contained in:
Sipke Schoorstra 2023-08-02 22:53:54 +02:00
parent e8b1c5efe1
commit 2475c251e3
1 changed files with 17 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

34
src/modules/Elsa.Workflows.Core/Services/IdentityGraphService.cs
View file

@ -42,8 +42,8 @@ public class IdentityGraphService : IIdentityGraphService
{
node.Activity.Id = CreateId(node, identityCounters, flattenedList);
AssignInputOutputs(node.Activity);
if(node.Activity is IVariableContainer variableContainer)
if (node.Activity is IVariableContainer variableContainer)
AssignVariables(variableContainer);
}
}
@ -52,32 +52,32 @@ public class IdentityGraphService : IIdentityGraphService
public void AssignInputOutputs(IActivity activity)
{
var activityDescriptor = _activityRegistry.Find(activity.Type, activity.Version) ?? throw new Exception("Activity descriptor not found");
var inputs = activityDescriptor.GetWrappedInputProperties(activity).Values.Where(x => x != null).Cast<Input>().ToList();
var inputs = activityDescriptor.GetWrappedInputProperties(activity).Values.Cast<Input>().ToList();
var seed = 0;
foreach (var input in inputs)
{
var blockReference = input.MemoryBlockReference();
if(string.IsNullOrEmpty(blockReference.Id))
blockReference.Id = $"{activity.Id}:input-{++seed}";
var blockReference = input?.MemoryBlockReference();
if (blockReference != null!)
if (string.IsNullOrEmpty(blockReference.Id))
blockReference.Id = $"{activity.Id}:input-{seed}";
seed++;
}
seed = 0;
var outputs = activity.GetOutputs();
var assignedOutputs = outputs.Where(x =>
{
var memoryBlockReference = x.Value.MemoryBlockReference();
return memoryBlockReference != null! && memoryBlockReference.Id == null!;
}).ToList();
foreach (var output in assignedOutputs)
foreach (var output in outputs)
{
var blockReference = output.Value.MemoryBlockReference();
if(string.IsNullOrEmpty(blockReference.Id))
blockReference.Id = $"{activity.Id}:output-{++seed}";
if (blockReference != null!)
if (string.IsNullOrEmpty(blockReference.Id))
blockReference.Id = $"{activity.Id}:output-{seed}";
seed++;
}
}