SemianiakaVY/elsa-core
1
0
Fork 0
Code Issues Pull requests Actions 1 Packages Projects Releases Wiki Activity

Refactor parameter naming in BulkUpsert logic.

Browse source 
Replaced loop index-based parameter naming with a sequential counter to simplify and standardize parameter generation. Improved code readability and removed redundant indexing, ensuring consistency across different database operations.
This commit is contained in:
Sipke Schoorstra 2025-02-17 18:24:14 +01:00
parent c08e7fc9a9
commit 2240a78dd3
1 changed files with 13 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
src/modules/Elsa.EntityFrameworkCore.Common/Extensions/BulkUpsertExtensions.cs
View file

@ -106,15 +106,16 @@ public static class BulkUpsertExtensions
mergeSql.AppendLine("USING (VALUES");
var parameters = new List<object>();
var parameterCount = 0;
for (var i = 0; i < entities.Count; i++)
{
var entity = entities[i];
var values = new List<string>();
for (var j = 0; j < props.Count; j++)
foreach (var property in props)
{
var property = props[j];
var paramName = $"@p{i}_{j}";
var paramName = $"{{{parameterCount++}}}";
// If it's a shadow property, retrieve value via Entry(..).Property(..)
object? value = property.IsShadowProperty()
@ -160,6 +161,7 @@ public static class BulkUpsertExtensions
var sb = new StringBuilder();
var parameters = new List<object>();
var parameterCount = 0;
sb.Append($"INSERT INTO \"{tableName}\" ({string.Join(", ", columnNames.Select(c => $"\"{c}\""))}) VALUES ");
@ -168,10 +170,9 @@ public static class BulkUpsertExtensions
var entity = entities[i];
var placeholders = new List<string>();
for (var j = 0; j < props.Count; j++)
foreach (var property in props)
{
var property = props[j];
var paramName = $"@p{i}_{j}";
var paramName = $"{{{parameterCount++}}}";
object? value = property.IsShadowProperty()
? dbContext.Entry(entity).Property(property.Name).CurrentValue
@ -276,6 +277,7 @@ public static class BulkUpsertExtensions
var sb = new StringBuilder();
var parameters = new List<object>();
var parameterCount = 0;
sb.Append($"INSERT INTO `{tableName}` ({string.Join(", ", columnNames.Select(c => $"`{c}`"))}) VALUES ");
@ -284,10 +286,9 @@ public static class BulkUpsertExtensions
var entity = entities[i];
var placeholders = new List<string>();
for (var j = 0; j < props.Count; j++)
foreach (var property in props)
{
var property = props[j];
var paramName = $"@p{i}_{j}";
var paramName = $"{{{parameterCount++}}}";
object? value = property.IsShadowProperty()
? dbContext.Entry(entity).Property(property.Name).CurrentValue
@ -337,6 +338,7 @@ public static class BulkUpsertExtensions
var sb = new StringBuilder();
var parameters = new List<object>();
var parameterCount = 0;
sb.AppendLine($"MERGE INTO {fullName} Target");
sb.AppendLine("USING (SELECT");
@ -346,10 +348,9 @@ public static class BulkUpsertExtensions
var entity = entities[i];
var lineParts = new List<string>();
for (var j = 0; j < props.Count; j++)
foreach (var property in props)
{
var property = props[j];
var paramName = $":p{i}_{j}";
var paramName = $"{{{parameterCount++}}}";
object? value = property.IsShadowProperty()
? dbContext.Entry(entity).Property(property.Name).CurrentValue