From 20d33f868297499db745579d506471fba0e344ae Mon Sep 17 00:00:00 2001 From: "lucas.hipolito" Date: Wed, 6 Aug 2025 12:01:08 +0200 Subject: [PATCH] Explaining the reasoning for the test fixes with comments --- .../ContainerSerialization/Tests.cs | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/test/integration/Elsa.Workflows.IntegrationTests/Serialization/ContainerSerialization/Tests.cs b/test/integration/Elsa.Workflows.IntegrationTests/Serialization/ContainerSerialization/Tests.cs index f49947e8d..e3f2c9716 100644 --- a/test/integration/Elsa.Workflows.IntegrationTests/Serialization/ContainerSerialization/Tests.cs +++ b/test/integration/Elsa.Workflows.IntegrationTests/Serialization/ContainerSerialization/Tests.cs @@ -32,20 +32,23 @@ public class Tests { Id = "start", Name = "Start", - RunAsynchronously = false + RunAsynchronously = false // Manually set to false because the manual construction defaults to null, + // But deserialization uses the factory creation method that overwrites null values. }; var writeLine = new WriteLine(new Input(new Expression("JavaScript", "getVariable('TextVar')"))) { Id = "writeLine", Name = "WriteLine", Version = 3, - RunAsynchronously = false + RunAsynchronously = false // Manually set to false because the manual construction defaults to null, + // But deserialization uses the factory creation method that overwrites null values. }; var end = new End { Id = "end", Name = "end", - RunAsynchronously = false + RunAsynchronously = false // Manually set to false because the manual construction defaults to null, + // But deserialization uses the factory creation method that overwrites null values. }; var container = new Flowchart { @@ -111,7 +114,8 @@ public class Tests Id = "writeLine", Name = "WriteLine", CanStartWorkflow = true, - RunAsynchronously = false + RunAsynchronously = false // Manually set to false because the manual construction defaults to null, + // But deserialization uses the factory creation method that overwrites null values. }, }, CustomProperties = new Dictionary @@ -159,7 +163,9 @@ public class Tests Id = "writeLine", Name = "WriteLine", CanStartWorkflow = true, - RunAsynchronously = false + RunAsynchronously = false // Manually set to false because the manual construction defaults to null, + // But deserialization uses the factory creation method that overwrites null values. + }, }, CustomProperties = new Dictionary