SemianiakaVY/elsa-core
1
0
Fork 0
Code Issues Pull requests Actions 1 Packages Projects Releases Wiki Activity

Remove warnings

Browse source
This commit is contained in:
Sipke Schoorstra 2020-12-02 22:31:26 +01:00
parent bf1d54d1e6
commit 17eea86c70
4 changed files with 11 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/core/Elsa.Core/Activities/ControlFlow/Join/Join.cs
View file

@ -72,7 +72,7 @@ namespace Elsa.Activities.ControlFlow
return Done();
}
private async Task RecordInboundTransitionsAsync(ActivityExecutionContext activityExecutionContext, CancellationToken cancellationToken)
private void RecordInboundTransitionsAsync(ActivityExecutionContext activityExecutionContext)
{
var workflowExecutionContext = activityExecutionContext.WorkflowExecutionContext;
var activityInstance = activityExecutionContext.ActivityInstance;
@ -117,9 +117,10 @@ namespace Elsa.Activities.ControlFlow
return $"@{sourceActivityId}_{sourceOutcomeName}";
}
public async Task Handle(ActivityExecuted notification, CancellationToken cancellationToken)
public Task Handle(ActivityExecuted notification, CancellationToken cancellationToken)
{
await RecordInboundTransitionsAsync(notification.ActivityExecutionContext, cancellationToken);
RecordInboundTransitionsAsync(notification.ActivityExecutionContext);
return Task.CompletedTask;
}
}
}

10
src/core/Elsa.Core/Activities/Primitives/Correlate/SetVariableBuilderExtensions.cs
View file

@ -10,10 +10,10 @@ namespace Elsa.Activities.ControlFlow
public static class CorrelateBuilderExtensions
{
public static IOutcomeBuilder Correlate(this IBuilder builder, Action<ISetupActivity<Correlate>> setup) => builder.Then(setup).When(OutcomeNames.Done);
public static IOutcomeBuilder Correlate(this IBuilder builder, Func<ActivityExecutionContext, ValueTask<string>> value) => builder.Correlate(activity => activity.Set(x => x.Value, value));
public static IOutcomeBuilder Correlate(this IBuilder builder, Func<ActivityExecutionContext, string> value) => builder.Correlate(activity => activity.Set(x => x.Value, value));
public static IOutcomeBuilder Correlate(this IBuilder builder, Func<ValueTask<string>> value) => builder.Correlate(activity => activity.Set(x => x.Value, value));
public static IOutcomeBuilder Correlate(this IBuilder builder, Func<string> value) => builder.Correlate(activity => activity.Set(x => x.Value, value));
public static IOutcomeBuilder Correlate(this IBuilder builder, string value) => builder.Correlate(activity => activity.Set(x => x.Value, value));
public static IOutcomeBuilder Correlate(this IBuilder builder, Func<ActivityExecutionContext, ValueTask<string?>> value) => builder.Correlate(activity => activity.Set(x => x.Value, value));
public static IOutcomeBuilder Correlate(this IBuilder builder, Func<ActivityExecutionContext, string?> value) => builder.Correlate(activity => activity.Set(x => x.Value, value));
public static IOutcomeBuilder Correlate(this IBuilder builder, Func<ValueTask<string?>> value) => builder.Correlate(activity => activity.Set(x => x.Value, value));
public static IOutcomeBuilder Correlate(this IBuilder builder, Func<string?> value) => builder.Correlate(activity => activity.Set(x => x.Value, value));
public static IOutcomeBuilder Correlate(this IBuilder builder, string? value) => builder.Correlate(activity => activity.Set(x => x.Value, value));
}
}

2
src/core/Elsa.Core/Builders/SetupActivity.cs
View file

@ -13,7 +13,7 @@ namespace Elsa.Builders
public IDictionary<string, Func<ActivityExecutionContext, ValueTask<object?>>> ValueProviders { get; } =
new Dictionary<string, Func<ActivityExecutionContext, ValueTask<object?>>>();
public ISetupActivity<T> Set<TProperty>(Expression<Func<T, TProperty>> propertyAccessor,
public ISetupActivity<T> Set<TProperty>(Expression<Func<T, TProperty?>> propertyAccessor,
Func<ActivityExecutionContext, ValueTask<TProperty?>> valueFactory)
{
var propertyInfo = propertyAccessor.GetProperty()!;

2
src/core/Elsa.Core/Services/WorkflowRunner.cs
View file

@ -66,7 +66,7 @@ namespace Elsa.Services
if (result.WorkflowInstanceId != null)
{
var workflowInstance = await _workflowInstanceManager.GetByIdAsync(result.WorkflowInstanceId, cancellationToken);
await RunWorkflowAsync(result.WorkflowBlueprint, workflowInstance, result.ActivityId, input, cancellationToken);
await RunWorkflowAsync(result.WorkflowBlueprint, workflowInstance!, result.ActivityId, input, cancellationToken);
}
else
await RunWorkflowAsync(result.WorkflowBlueprint, result.ActivityId, input, correlationId, contextId, cancellationToken);