From 12408cca37e11e74e5674ca2cef5cb712dfb174f Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Wed, 20 May 2026 23:43:25 +0000 Subject: [PATCH] Address validation feedback Agent-Logs-Url: https://github.com/elsa-workflows/elsa-core/sessions/6a652ca4-f0c8-4284-938d-6de0eb7a2bea Co-authored-by: sfmskywalker <938393+sfmskywalker@users.noreply.github.com> --- .../HealthChecks/ElsaWorkflowPersistenceHealthCheck.cs | 1 + .../HealthChecks/ElsaDistributedLockHealthCheckTests.cs | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/modules/Elsa.Workflows.Runtime/HealthChecks/ElsaWorkflowPersistenceHealthCheck.cs b/src/modules/Elsa.Workflows.Runtime/HealthChecks/ElsaWorkflowPersistenceHealthCheck.cs index 529f54547..41bd1046c 100644 --- a/src/modules/Elsa.Workflows.Runtime/HealthChecks/ElsaWorkflowPersistenceHealthCheck.cs +++ b/src/modules/Elsa.Workflows.Runtime/HealthChecks/ElsaWorkflowPersistenceHealthCheck.cs @@ -18,6 +18,7 @@ public class ElsaWorkflowPersistenceHealthCheck(IServiceProvider serviceProvider /// public async Task CheckHealthAsync(HealthCheckContext context, CancellationToken cancellationToken = default) { + // These probes verify store reachability only; returned entities and counts are intentionally ignored. var probeResults = new List { await ProbeAsync("workflow-definitions", serviceProvider.GetService(), async (store, ct) => diff --git a/test/unit/Elsa.Workflows.Runtime.UnitTests/HealthChecks/ElsaDistributedLockHealthCheckTests.cs b/test/unit/Elsa.Workflows.Runtime.UnitTests/HealthChecks/ElsaDistributedLockHealthCheckTests.cs index d4e8e888a..115456c40 100644 --- a/test/unit/Elsa.Workflows.Runtime.UnitTests/HealthChecks/ElsaDistributedLockHealthCheckTests.cs +++ b/test/unit/Elsa.Workflows.Runtime.UnitTests/HealthChecks/ElsaDistributedLockHealthCheckTests.cs @@ -50,7 +50,7 @@ public class ElsaDistributedLockHealthCheckTests await sut.CheckHealthAsync(new HealthCheckContext()); Assert.Equal(2, lockNames.Count); - Assert.All(lockNames, x => Assert.DoesNotContain(Environment.MachineName, x, StringComparison.Ordinal)); + Assert.All(lockNames, x => Assert.DoesNotContain(Environment.MachineName, x, StringComparison.OrdinalIgnoreCase)); Assert.NotEqual(lockNames[0], lockNames[1]); }