From 116ede9260fc533af931d55e2e7e7e2d4311df41 Mon Sep 17 00:00:00 2001 From: Sipke Schoorstra Date: Wed, 24 Nov 2021 14:29:56 +0100 Subject: [PATCH] Prevent activities with [Browasable(false)] from being included Fixes #2411 --- src/core/Elsa.Core/Metadata/TypedActivityTypeDescriber.cs | 2 +- .../Providers/ActivityTypes/TypeBasedActivityProvider.cs | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/src/core/Elsa.Core/Metadata/TypedActivityTypeDescriber.cs b/src/core/Elsa.Core/Metadata/TypedActivityTypeDescriber.cs index 68aea1134..465b74fba 100644 --- a/src/core/Elsa.Core/Metadata/TypedActivityTypeDescriber.cs +++ b/src/core/Elsa.Core/Metadata/TypedActivityTypeDescriber.cs @@ -47,7 +47,7 @@ namespace Elsa.Metadata Traits = traits, InputProperties = inputProperties.ToArray(), OutputProperties = outputProperties.ToArray(), - Outcomes = outcomes, + Outcomes = outcomes }; } diff --git a/src/core/Elsa.Core/Providers/ActivityTypes/TypeBasedActivityProvider.cs b/src/core/Elsa.Core/Providers/ActivityTypes/TypeBasedActivityProvider.cs index afa10bc59..e1e48b49e 100644 --- a/src/core/Elsa.Core/Providers/ActivityTypes/TypeBasedActivityProvider.cs +++ b/src/core/Elsa.Core/Providers/ActivityTypes/TypeBasedActivityProvider.cs @@ -1,6 +1,8 @@ using System; using System.Collections.Generic; +using System.ComponentModel; using System.Linq; +using System.Reflection; using System.Runtime.CompilerServices; using System.Threading; using System.Threading.Tasks; @@ -54,6 +56,7 @@ namespace Elsa.Providers.ActivityTypes Type = activityType, Description = info.Description, DisplayName = info.DisplayName, + IsBrowsable = activityType.GetCustomAttribute()?.Browsable ?? true, ActivateAsync = async context => await ActivateActivity(context, activityType), DescribeAsync = async () => (await _describesActivityType.DescribeAsync(activityType, cancellationToken))!, CanExecuteAsync = async (context, instance) => await instance.CanExecuteAsync(context),