From 0ecc09438eb4a8016ee3bb8b8c9df54cd3a23930 Mon Sep 17 00:00:00 2001 From: Sipke Schoorstra Date: Fri, 5 Apr 2024 20:17:47 +0200 Subject: [PATCH] Update project reference and cleanup code A reference to Elsa.EntityFrameworkCore.Sqlite.csproj was added in the Elsa.Samples.AspNet.DynamicActivityProvider.csproj, providing SQLite support. The Add method in ExpressionDescriptorRegistry.cs was reformatted for better readability. In the Program.cs file, the signing key was updated to meet the minimum length requirement and some unnecessary comments were removed. --- .../Elsa.Samples.AspNet.DynamicActivityProvider.csproj | 1 + .../Elsa.Samples.AspNet.DynamicActivityProvider/Program.cs | 7 ++----- .../Services/ExpressionDescriptorRegistry.cs | 7 +++++-- 3 files changed, 8 insertions(+), 7 deletions(-) diff --git a/samples/aspnet/Elsa.Samples.AspNet.DynamicActivityProvider/Elsa.Samples.AspNet.DynamicActivityProvider.csproj b/samples/aspnet/Elsa.Samples.AspNet.DynamicActivityProvider/Elsa.Samples.AspNet.DynamicActivityProvider.csproj index 390f36768..13497c81c 100644 --- a/samples/aspnet/Elsa.Samples.AspNet.DynamicActivityProvider/Elsa.Samples.AspNet.DynamicActivityProvider.csproj +++ b/samples/aspnet/Elsa.Samples.AspNet.DynamicActivityProvider/Elsa.Samples.AspNet.DynamicActivityProvider.csproj @@ -6,6 +6,7 @@ + diff --git a/samples/aspnet/Elsa.Samples.AspNet.DynamicActivityProvider/Program.cs b/samples/aspnet/Elsa.Samples.AspNet.DynamicActivityProvider/Program.cs index a9d40ff2d..81bae69e4 100644 --- a/samples/aspnet/Elsa.Samples.AspNet.DynamicActivityProvider/Program.cs +++ b/samples/aspnet/Elsa.Samples.AspNet.DynamicActivityProvider/Program.cs @@ -22,15 +22,12 @@ services.AddElsa(elsa => elsa identity.UseEntityFrameworkCore(); identity.TokenOptions = options => { - options.SigningKey = "secret-token-signing-key"; + options.SigningKey = "secret-token-signing-key-with-a-minimum-length-of-256-bits"; options.AccessTokenLifetime = TimeSpan.FromDays(1); }; }) - - // HTTP workflows. + .UseJavaScript() .UseHttp() - - // Use default authentication (JWT). .UseDefaultAuthentication(auth => auth.UseAdminApiKey()) ); diff --git a/src/modules/Elsa.Workflows.Management/Services/ExpressionDescriptorRegistry.cs b/src/modules/Elsa.Workflows.Management/Services/ExpressionDescriptorRegistry.cs index ff181ff10..f8ba229d9 100644 --- a/src/modules/Elsa.Workflows.Management/Services/ExpressionDescriptorRegistry.cs +++ b/src/modules/Elsa.Workflows.Management/Services/ExpressionDescriptorRegistry.cs @@ -19,7 +19,10 @@ public class ExpressionDescriptorRegistry : IExpressionDescriptorRegistry } /// - public void Add(ExpressionDescriptor descriptor) => _expressionSyntaxDescriptors[descriptor.Type] = descriptor; + public void Add(ExpressionDescriptor descriptor) + { + _expressionSyntaxDescriptors[descriptor.Type] = descriptor; + } /// public void AddRange(IEnumerable descriptors) @@ -35,5 +38,5 @@ public class ExpressionDescriptorRegistry : IExpressionDescriptorRegistry public ExpressionDescriptor? Find(Func predicate) => _expressionSyntaxDescriptors.Values.FirstOrDefault(predicate); /// - public ExpressionDescriptor? Find(string type) => _expressionSyntaxDescriptors.TryGetValue(type, out var descriptor) ? descriptor : default!; + public ExpressionDescriptor? Find(string type) => _expressionSyntaxDescriptors.TryGetValue(type, out var descriptor) ? descriptor : default; } \ No newline at end of file