SemianiakaVY/elsa-core
1
0
Fork 0
Code Issues Pull requests Actions 1 Packages Projects Releases Wiki Activity

Fixed stackoverflow when finding ancestors (#247)

Browse source
This commit is contained in:
James Doran 2020-02-17 18:06:40 +10:30 committed by GitHub
parent 48be0e8a87
commit 0e9cd54c2e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
src/core/Elsa.Abstractions/Services/Extensions/WorkflowExtensions.cs
View file

@ -58,24 +58,31 @@ namespace Elsa.Services.Extensions
/// </summary>
public static IEnumerable<string> GetInboundActivityPath(this Workflow workflow, string activityId)
{
return workflow.GetInboundActivityPathInternal(activityId, activityId).Distinct().ToList();
var inspectedActivityIDs = new HashSet<string>();
return workflow.GetInboundActivityPathInternal(activityId, activityId, inspectedActivityIDs)
.Distinct().ToList();
}
private static IEnumerable<string> GetInboundActivityPathInternal(this Workflow workflowInstance,
string activityId, string startingPointActivityId)
string activityId,
string startingPointActivityId,
HashSet<string> inspectedActivityIDs)
{
foreach (var connection in workflowInstance.GetInboundConnections(activityId))
{
// Circuit breaker: Detect workflows that implement repeating flows to prevent an infinite loop here.
if (connection.Source.Activity.Id == startingPointActivityId)
if (inspectedActivityIDs.Contains(connection.Source.Activity.Id))
yield break;
yield return connection.Source.Activity.Id;
foreach (var parentActivityId in workflowInstance
.GetInboundActivityPathInternal(connection.Source.Activity.Id, startingPointActivityId)
.Distinct())
foreach (var parentActivityId in workflowInstance.GetInboundActivityPathInternal(connection.Source.Activity.Id, startingPointActivityId, inspectedActivityIDs)
.Distinct())
{
inspectedActivityIDs.Add(parentActivityId);
yield return parentActivityId;
}
}
}
}