SemianiakaVY/elsa-core
1
0
Fork 0
Code Issues Pull requests Actions 1 Packages Projects Releases Wiki Activity

Harden alteration timestamp filter integration tests

Browse source
This commit is contained in:
Sipke Schoorstra 2026-05-21 01:33:53 +02:00
parent 4b824d65b8
commit 008e5a3f21
No known key found for this signature in database
GPG key ID: 5C10502B28A4268F
2 changed files with 11 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
test/integration/Elsa.Alterations.IntegrationTests/AlterationsApiTimestampFilterTests.cs
View file

@ -21,7 +21,8 @@ public class AlterationsApiTimestampFilterTests : IAsyncLifetime
{
private WebApplication? _app;
private bool _wasSecurityEnabled;
private HttpClient _httpClient = null!;
private HttpClient? _httpClient;
private HttpClient HttpClient => _httpClient ?? throw new InvalidOperationException("The test HTTP client has not been initialized.");
public async Task InitializeAsync()
{
@ -58,7 +59,7 @@ public class AlterationsApiTimestampFilterTests : IAsyncLifetime
public async Task DisposeAsync()
{
EndpointSecurityOptions.SecurityIsEnabled = _wasSecurityEnabled;
_httpClient.Dispose();
_httpClient?.Dispose();
if (_app == null)
return;
@ -72,7 +73,7 @@ public class AlterationsApiTimestampFilterTests : IAsyncLifetime
[InlineData("/alterations/submit")]
public async Task Post_WithInjectedTimestampFilterColumn_ReturnsBadRequest(string path)
{
var response = await _httpClient.PostAsJsonAsync(path, CreateRequest(path));
var response = await HttpClient.PostAsJsonAsync(path, CreateRequest(path));
var body = await response.Content.ReadAsStringAsync();
Assert.Equal(HttpStatusCode.BadRequest, response.StatusCode);
@ -82,9 +83,9 @@ public class AlterationsApiTimestampFilterTests : IAsyncLifetime
[Fact]
public async Task Submit_WithNullFilter_DoesNotReturnServerError()
{
var response = await _httpClient.PostAsJsonAsync("/alterations/submit", new { filter = (object?)null });
var response = await HttpClient.PostAsJsonAsync("/alterations/submit", new { filter = (object?)null });
Assert.NotEqual(HttpStatusCode.InternalServerError, response.StatusCode);
Assert.Equal(HttpStatusCode.OK, response.StatusCode);
}
[Theory]
@ -92,7 +93,7 @@ public class AlterationsApiTimestampFilterTests : IAsyncLifetime
[InlineData("/alterations/submit")]
public async Task Post_WithNullTimestampFilter_ReturnsBadRequest(string path)
{
var response = await _httpClient.PostAsJsonAsync(path, CreateRequestWithNullTimestampFilter(path));
var response = await HttpClient.PostAsJsonAsync(path, CreateRequestWithNullTimestampFilter(path));
var body = await response.Content.ReadAsStringAsync();
Assert.Equal(HttpStatusCode.BadRequest, response.StatusCode);
@ -104,7 +105,7 @@ public class AlterationsApiTimestampFilterTests : IAsyncLifetime
[InlineData("/alterations/submit")]
public async Task Post_WithMultipleInvalidTimestampFilters_ReturnsAllValidationErrors(string path)
{
var response = await _httpClient.PostAsJsonAsync(path, CreateRequestWithMultipleInvalidTimestampFilters(path));
var response = await HttpClient.PostAsJsonAsync(path, CreateRequestWithMultipleInvalidTimestampFilters(path));
var body = await response.Content.ReadAsStringAsync();
Assert.Equal(HttpStatusCode.BadRequest, response.StatusCode);

3
test/integration/Elsa.Alterations.IntegrationTests/AssemblyInfo.cs Normal file
View file

@ -0,0 +1,3 @@
using Xunit;
[assembly: CollectionBehavior(DisableTestParallelization = true)]