SemianiakaVY/BotSharp
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

1.IgnoreIfNotFound defaults to true

Browse source 
2.Fix the incomplete log issue
This commit is contained in:
nick.yi 2025-06-17 15:52:04 +08:00
parent cbac4627c3
commit bb0be151c3
2 changed files with 12 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/Infrastructure/BotSharp.Abstraction/Browsing/Models/ElementLocatingArgs.cs
View file

@ -30,7 +30,7 @@ public class ElementLocatingArgs
public bool FailIfMultiple { get; set; }
[JsonPropertyName("ignore_if_not_found")]
public bool IgnoreIfNotFound { get; set; }
public bool IgnoreIfNotFound { get; set; } = true;
/// <summary>
/// Draw outline around the element

16
src/Plugins/BotSharp.Plugin.WebDriver/Drivers/PlaywrightDriver/PlaywrightWebDriver.LocateElement.cs
View file

@ -23,16 +23,19 @@ public partial class PlaywrightWebDriver
}
ILocator locator = page.Locator("body");
int count = 0;
var keyword = string.Empty;
// check if selector is specified
if (location.Selector != null)
{
keyword = location.Selector;
locator = locator.Locator(location.Selector);
count = await locator.CountAsync();
}
if (location.Tag != null)
{
keyword = location.Tag;
locator = page.Locator(location.Tag);
count = await locator.CountAsync();
}
@ -40,13 +43,15 @@ public partial class PlaywrightWebDriver
// try attribute
if (!string.IsNullOrEmpty(location.AttributeName))
{
locator = locator.Locator($"[{location.AttributeName}='{location.AttributeValue}']");
keyword = $"[{location.AttributeName}='{location.AttributeValue}']";
locator = locator.Locator(keyword);
count = await locator.CountAsync();
}
// Retrieve the page raw html and infer the element path
if (!string.IsNullOrEmpty(location.Text))
{
keyword = location.Text;
var text = location.Text.Replace("(", "\\(").Replace(")", "\\)");
var regexExpression = location.MatchRule.ToLower() switch
{
@ -69,6 +74,7 @@ public partial class PlaywrightWebDriver
if (location.Index >= 0)
{
keyword = $"Index:{location.Index}";
locator = locator.Nth(location.Index);
count = await locator.CountAsync();
}
@ -77,13 +83,13 @@ public partial class PlaywrightWebDriver
{
if (location.IgnoreIfNotFound)
{
result.Message = $"Can't locate element by keyword {location.Text} and Ignored";
_logger.LogInformation(result.Message);
result.Message = $"Can't locate element by keyword {keyword} and Ignored";
_logger.LogWarning(result.Message);
}
else
{
result.Message = $"Can't locate element by keyword {location.Text}";
_logger.LogInformation(result.Message);
result.Message = $"Can't locate element by keyword {keyword}";
_logger.LogError(result.Message);
}
}