From a537a647cdf0d4b15f94d3b7b27b4b9f6d1bcaaa Mon Sep 17 00:00:00 2001
From: Haiping Chen <hchen@lessen.com>
Date: Tue, 11 Mar 2025 17:20:44 -0500
Subject: [PATCH] politely ending phone call

---
 .../Functions/HangupPhoneCallFn.cs            | 24 +++++++++++++------
 .../LlmContexts/HangupPhoneCallArgs.cs        |  9 +++++++
 .../LlmContexts/LlmContextIn.cs               |  4 ++--
 .../util-twilio-hangup_phone_call.json        |  6 ++++-
 4 files changed, 33 insertions(+), 10 deletions(-)
 create mode 100644 src/Plugins/BotSharp.Plugin.Twilio/OutboundPhoneCallHandler/LlmContexts/HangupPhoneCallArgs.cs

diff --git a/src/Plugins/BotSharp.Plugin.Twilio/OutboundPhoneCallHandler/Functions/HangupPhoneCallFn.cs b/src/Plugins/BotSharp.Plugin.Twilio/OutboundPhoneCallHandler/Functions/HangupPhoneCallFn.cs
index f54c1b42..bc1bad36 100644
--- a/src/Plugins/BotSharp.Plugin.Twilio/OutboundPhoneCallHandler/Functions/HangupPhoneCallFn.cs
+++ b/src/Plugins/BotSharp.Plugin.Twilio/OutboundPhoneCallHandler/Functions/HangupPhoneCallFn.cs
@@ -1,4 +1,7 @@
+using BotSharp.Plugin.Twilio.OutboundPhoneCallHandler.LlmContexts;
+using Microsoft.VisualBasic;
 using Twilio.Rest.Api.V2010.Account;
+using Task = System.Threading.Tasks.Task;
 
 namespace BotSharp.Plugin.Twilio.OutboundPhoneCallHandler.Functions;
 
@@ -20,6 +23,7 @@ public class HangupPhoneCallFn : IFunctionCallback
 
     public async Task<bool> Execute(RoleDialogModel message)
     {
+        var args = JsonSerializer.Deserialize<HangupPhoneCallArgs>(message.FunctionArgs);
         var states = _services.GetRequiredService<IConversationStateService>();
         var callSid = states.GetState("twilio_call_sid");
 
@@ -30,14 +34,20 @@ public class HangupPhoneCallFn : IFunctionCallback
             return false;
         }
 
-        // Have to find the SID by the phone number
-        var call = CallResource.Update(
-            status: CallResource.UpdateStatusEnum.Completed,
-            pathSid: callSid
-        );
+        message.Content = args.GoodbyeMessage;
 
-        message.Content = "The call has ended.";
-        message.StopCompletion = true;
+        _ = Task.Run(async () =>
+        {
+            await Task.Delay(args.GoodbyeMessage.Split(' ').Length * 400);
+            // Have to find the SID by the phone number
+            var call = CallResource.Update(
+                status: CallResource.UpdateStatusEnum.Completed,
+                pathSid: callSid
+            );
+
+            message.Content = "The call has ended.";
+            message.StopCompletion = true;
+        });
 
         return true;
     }
diff --git a/src/Plugins/BotSharp.Plugin.Twilio/OutboundPhoneCallHandler/LlmContexts/HangupPhoneCallArgs.cs b/src/Plugins/BotSharp.Plugin.Twilio/OutboundPhoneCallHandler/LlmContexts/HangupPhoneCallArgs.cs
new file mode 100644
index 00000000..ea2075d9
--- /dev/null
+++ b/src/Plugins/BotSharp.Plugin.Twilio/OutboundPhoneCallHandler/LlmContexts/HangupPhoneCallArgs.cs
@@ -0,0 +1,9 @@
+using System.Text.Json.Serialization;
+
+namespace BotSharp.Plugin.Twilio.OutboundPhoneCallHandler.LlmContexts;
+
+public class HangupPhoneCallArgs
+{
+    [JsonPropertyName("goodbye_message")]
+    public string? GoodbyeMessage { get; set; }
+}
diff --git a/src/Plugins/BotSharp.Plugin.Twilio/OutboundPhoneCallHandler/LlmContexts/LlmContextIn.cs b/src/Plugins/BotSharp.Plugin.Twilio/OutboundPhoneCallHandler/LlmContexts/LlmContextIn.cs
index cde85aa9..3f7ea8b6 100644
--- a/src/Plugins/BotSharp.Plugin.Twilio/OutboundPhoneCallHandler/LlmContexts/LlmContextIn.cs
+++ b/src/Plugins/BotSharp.Plugin.Twilio/OutboundPhoneCallHandler/LlmContexts/LlmContextIn.cs
@@ -5,8 +5,8 @@ namespace BotSharp.Plugin.Twilio.OutboundPhoneCallHandler.LlmContexts;
 public class LlmContextIn
 {
     [JsonPropertyName("phone_number")]
-    public string PhoneNumber { get; set; }
+    public string PhoneNumber { get; set; } = null!;
 
     [JsonPropertyName("initial_message")]
-    public string InitialMessage { get; set; }
+    public string? InitialMessage { get; set; }
 }
diff --git a/src/Plugins/BotSharp.Plugin.Twilio/data/agents/6745151e-6d46-4a02-8de4-1c4f21c7da95/functions/util-twilio-hangup_phone_call.json b/src/Plugins/BotSharp.Plugin.Twilio/data/agents/6745151e-6d46-4a02-8de4-1c4f21c7da95/functions/util-twilio-hangup_phone_call.json
index 76b0e841..773fac23 100644
--- a/src/Plugins/BotSharp.Plugin.Twilio/data/agents/6745151e-6d46-4a02-8de4-1c4f21c7da95/functions/util-twilio-hangup_phone_call.json
+++ b/src/Plugins/BotSharp.Plugin.Twilio/data/agents/6745151e-6d46-4a02-8de4-1c4f21c7da95/functions/util-twilio-hangup_phone_call.json
@@ -5,7 +5,11 @@
   "parameters": {
     "type": "object",
     "properties": {
+      "goodbye_message": {
+        "type": "string",
+        "description": "A polite closing statement for ending a conversation."
+      }
     },
-    "required": []
+    "required": [ "goodbye_message" ]
   }
 }
\ No newline at end of file