From 45fd30aaf84a64c1806bbffd872489419b79531f Mon Sep 17 00:00:00 2001
From: Jicheng Lu <103353@smsassist.com>
Date: Wed, 10 Apr 2024 12:45:35 -0500
Subject: [PATCH] add readonly load state

---
 .../Conversations/IConversationStateService.cs              | 2 +-
 .../Conversations/Services/ConversationStateService.cs      | 6 +++---
 .../BotSharp.OpenAPI/Controllers/ConversationController.cs  | 2 +-
 .../Repository/MongoRepository.Conversation.cs              | 5 +----
 4 files changed, 6 insertions(+), 9 deletions(-)

diff --git a/src/Infrastructure/BotSharp.Abstraction/Conversations/IConversationStateService.cs b/src/Infrastructure/BotSharp.Abstraction/Conversations/IConversationStateService.cs
index 655e657a..fe3f9193 100644
--- a/src/Infrastructure/BotSharp.Abstraction/Conversations/IConversationStateService.cs
+++ b/src/Infrastructure/BotSharp.Abstraction/Conversations/IConversationStateService.cs
@@ -9,7 +9,7 @@ namespace BotSharp.Abstraction.Conversations;
 public interface IConversationStateService
 {
     string GetConversationId();
-    Dictionary<string, string> Load(string conversationId);
+    Dictionary<string, string> Load(string conversationId, bool isReadOnly = false);
     string GetState(string name, string defaultValue = "");
     bool ContainsState(string name);
     Dictionary<string, string> GetStates();
diff --git a/src/Infrastructure/BotSharp.Core/Conversations/Services/ConversationStateService.cs b/src/Infrastructure/BotSharp.Core/Conversations/Services/ConversationStateService.cs
index 36b2ddeb..7a08b10b 100644
--- a/src/Infrastructure/BotSharp.Core/Conversations/Services/ConversationStateService.cs
+++ b/src/Infrastructure/BotSharp.Core/Conversations/Services/ConversationStateService.cs
@@ -117,9 +117,9 @@ public class ConversationStateService : IConversationStateService, IDisposable
         return this;
     }
 
-    public Dictionary<string, string> Load(string conversationId)
+    public Dictionary<string, string> Load(string conversationId, bool isReadOnly = false)
     {
-        _conversationId = conversationId;
+        _conversationId = !isReadOnly ? conversationId : null;
 
         var routingCtx = _services.GetRequiredService<IRoutingContext>();
         var curMsgId = routingCtx.MessageId;
@@ -320,7 +320,7 @@ public class ConversationStateService : IConversationStateService, IDisposable
 
     public void Dispose()
     {
-        Save();
+        
     }
 
     public bool ContainsState(string name)
diff --git a/src/Infrastructure/BotSharp.OpenAPI/Controllers/ConversationController.cs b/src/Infrastructure/BotSharp.OpenAPI/Controllers/ConversationController.cs
index e01a0f46..8bf3b757 100644
--- a/src/Infrastructure/BotSharp.OpenAPI/Controllers/ConversationController.cs
+++ b/src/Infrastructure/BotSharp.OpenAPI/Controllers/ConversationController.cs
@@ -125,7 +125,7 @@ public class ConversationController : ControllerBase
         var result = ConversationViewModel.FromSession(conversations.Items.First());
 
         var state = _services.GetRequiredService<IConversationStateService>();
-        result.States = state.Load(conversationId);
+        result.States = state.Load(conversationId, isReadOnly: true);
 
         var user = await userService.GetUser(result.User.Id);
         result.User = UserViewModel.FromUser(user);
diff --git a/src/Plugins/BotSharp.Plugin.MongoStorage/Repository/MongoRepository.Conversation.cs b/src/Plugins/BotSharp.Plugin.MongoStorage/Repository/MongoRepository.Conversation.cs
index ac5a47d5..ed15803e 100644
--- a/src/Plugins/BotSharp.Plugin.MongoStorage/Repository/MongoRepository.Conversation.cs
+++ b/src/Plugins/BotSharp.Plugin.MongoStorage/Repository/MongoRepository.Conversation.cs
@@ -191,14 +191,11 @@ public partial class MongoRepository
     {
         if (string.IsNullOrEmpty(conversationId) || states == null) return;
 
-        var filterConv = Builders<ConversationDocument>.Filter.Eq(x => x.Id, conversationId);
         var filterStates = Builders<ConversationStateDocument>.Filter.Eq(x => x.ConversationId, conversationId);
         var saveStates = states.Select(x => StateMongoElement.ToMongoElement(x)).ToList();
         var updateStates = Builders<ConversationStateDocument>.Update.Set(x => x.States, saveStates);
-        var updateConv = Builders<ConversationDocument>.Update.Set(x => x.UpdatedTime, DateTime.UtcNow);
 
         _dc.ConversationStates.UpdateOne(filterStates, updateStates);
-        _dc.Conversations.UpdateOne(filterConv, updateConv);
     }
 
     public void UpdateConversationStatus(string conversationId, string status)
@@ -391,7 +388,7 @@ public partial class MongoRepository
         {
             var skip = (page - 1) * batchSize;
             var candidates = _dc.Conversations.AsQueryable()
-                                              .Where(x => (x.DialogCount <= messageLimit) && x.UpdatedTime <= utcNow.AddHours(-bufferHours))
+                                              .Where(x => x.DialogCount <= messageLimit && x.UpdatedTime <= utcNow.AddHours(-bufferHours))
                                               .Skip(skip)
                                               .Take(batchSize)
                                               .Select(x => x.Id)